Skip to content

Add Sublime Text editor support - #9220

Closed
niksy wants to merge 1 commit into
pingdotgg:mainfrom
niksy:sublime-text
Closed

niksy wants to merge 1 commit into
pingdotgg:mainfrom
niksy:sublime-text

Conversation

@niksy

@niksy niksy commented Sep 2, 2026 •

Copy link
Copy Markdown

What Changed

Added Sublime Text editor support. Based on Zed editor support since they share approach on how to handle files and file lines.

Why

Sublime Text is popular code/text editor with extensive plugin support for LSP and IDE capabilities.

UI Changes

Add the Sublime Text icon to the open drop down

Screenshot 2026-09-02 at 13 35 38

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Additive editor registration and UI only; no auth or data-path changes. Launch behavior depends on subl being on PATH when probed.

Overview
Adds Sublime Text as a selectable target for the chat/workspace Open in editor flow.

The shared EDITORS contract now includes sublime-text with the subl CLI and direct-path launch style (same approach as Zed), so server probing and local launch can treat it like other path-based editors. The web Open in picker shows a new Sublime icon and menu entry when the server reports the editor as available.

Label tests cover "Sublime Text" / "Open in Sublime Text", and config decode/session tests expect sublime-text to survive forward-compatible filtering alongside known editor ids.

Reviewed by Cursor Bugbot for commit 1e844e3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add sublime-text editor support to open-in picker and shared editor definitions

  • Adds a sublime-text editor definition to the shared EDITORS map in editor.ts with the subl command and direct-path launch style
  • Adds a SublimeTextIcon SVG component in Icons.tsx and wires it into the open-in picker in OpenInPicker.tsx so the option appears when availableEditors includes sublime-text
  • Updates tests in editorLabels.test.ts, session.test.ts, and server.test.ts to assert the label, menu text, and config decoding for sublime-text

Macroscope summarized 1e844e3.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 2, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — Adding Sublime Text is mostly a contained editor integration, but inserting it into the ordered shared editor registry can change the fallback preferred editor for installations without a saved preference. That product-default change warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@sethherr

Copy link
Copy Markdown

I would also really appreciate this - I understand the issue with the fallback, I'm happy to make improvements if it would make it possible to approve this

Copy link
Copy Markdown
Member

Note

This comment is posted by Julius' dot

The only screenshot shows Sublime Text in the updated Open menu. The PR supplies no before image or focused verification results showing that the new editor target launches with the intended workspace, file and line. The verification rule requires before/after UI evidence and checks of the changed behavior; checked boxes alone are insufficient. Please add the comparison and describe your environment, launch checks, observed results and any limitations, then request reconsideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants