Repository navigation
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — Adding Sublime Text is mostly a contained editor integration, but inserting it into the ordered shared editor registry can change the fallback preferred editor for installations without a saved preference. That product-default change warrants human review. You can add or adjust custom eligibility rules. Learn more. |
|
I would also really appreciate this - I understand the issue with the fallback, I'm happy to make improvements if it would make it possible to approve this |
|
Note This comment is posted by Julius' dot The only screenshot shows Sublime Text in the updated Open menu. The PR supplies no before image or focused verification results showing that the new editor target launches with the intended workspace, file and line. The verification rule requires before/after UI evidence and checks of the changed behavior; checked boxes alone are insufficient. Please add the comparison and describe your environment, launch checks, observed results and any limitations, then request reconsideration. |
What Changed
Added Sublime Text editor support. Based on Zed editor support since they share approach on how to handle files and file lines.
Why
Sublime Text is popular code/text editor with extensive plugin support for LSP and IDE capabilities.
UI Changes
Add the Sublime Text icon to the open drop down
Checklist
Note
Low Risk
Additive editor registration and UI only; no auth or data-path changes. Launch behavior depends on
sublbeing on PATH when probed.Overview
Adds Sublime Text as a selectable target for the chat/workspace Open in editor flow.
The shared
EDITORScontract now includessublime-textwith thesublCLI anddirect-pathlaunch style (same approach as Zed), so server probing and local launch can treat it like other path-based editors. The web Open in picker shows a new Sublime icon and menu entry when the server reports the editor as available.Label tests cover "Sublime Text" / "Open in Sublime Text", and config decode/session tests expect
sublime-textto survive forward-compatible filtering alongside known editor ids.Reviewed by Cursor Bugbot for commit 1e844e3. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add
sublime-texteditor support to open-in picker and shared editor definitionssublime-texteditor definition to the sharedEDITORSmap in editor.ts with thesublcommand anddirect-pathlaunch styleSublimeTextIconSVG component in Icons.tsx and wires it into the open-in picker in OpenInPicker.tsx so the option appears whenavailableEditorsincludessublime-textsublime-textMacroscope summarized 1e844e3.