Skip to content

fix(chat): smooth worktree setup status - #8922

Merged
juliusmarminge merged 3 commits into
mainfrom
smooth-worktree-setup-logs
Aug 31, 2026
Merged

fix(chat): smooth worktree setup status#8922
juliusmarminge merged 3 commits into
mainfrom
smooth-worktree-setup-logs

fix(web): restore Thinking after worktree setup

4b10ed5
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Aug 31, 2026 in 37s

Effect Service Conventions: No issues found

No Effect service conventions violations found. This pull request only changes React UI components, timeline presentation logic, and pure helper/test code; it does not create, move, refactor, or consume an Effect service.

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Files reviewed within scope:

  • apps/mobile/src/features/threads/NewTaskDraftScreen.tsx, apps/mobile/src/features/threads/thread-work-log.tsx — React component changes plus an export widening for ShimmeringWorkContent.
  • apps/mobile/src/lib/threadActivity.ts / .test.ts, apps/web/src/session-logic.ts / .test.ts — pure derivation logic filtering routine worktree setup activities, with tests.
  • apps/web/src/components/ChatView.logic.ts / .test.ts, apps/web/src/routes/_chat.draft.$draftId.tsx — pure predicate signature change from serverThreadStarted to a Pick<Thread, ...> value; call site updated and the now-unused threadHasStarted import removed.
  • apps/web/src/components/ChatView.tsx, chat/ChatComposer.tsx, chat/MessagesTimeline.tsx, chat/timelineScrollAnchoring.ts — presentation/scroll-anchoring constant relocation and rendering changes.
  • packages/client-runtime/src/work-log/presentation.ts — adds the pure predicate isWorktreeSetupActivity; consumers use a plain named import, which is correct for a pure helper module under these conventions.

Checks performed: no Context.Service tags, make/layer exports, Layer.succeed, ManagedRuntime.make, runPromise/runPromiseExit, tagged error classes, or catchTag/catchIf usage appear anywhere in the changed lines. No new lint/type-checker suppression directives were introduced. Tests added are for genuine behavior changes (setup-activity filtering, draft promotion timing), not to prove a mechanical refactor.

🔍 Agent activity — 3 tool calls

💭 This PR looks purely UI-focused, touching React components and a client-runtime presentation helper without creating, moving, or refactoring any Effect services, so there's likely nothing to flag here. I want to double-check the presentation.ts file just to be sure there's no Effect-related usage before concluding there are no findings.

1. browse_code — packages/client-runtime/src/work-log/presentation.ts

2. browse_code — apps/web/src/components/chat/timelineScrollAnchoring.ts

💭 No Effect service code was touched there, so that's clear. But I'm noticing a possible issue in MessagesTimeline.tsx where a // comment appears inside JSX—if that's within JSX children rather than an expression, it would render as literal text instead of being treated as a comment, so I want to check the actual file context to confirm whether this is a real bug.

3. browse_code — apps/web/src/components/chat/MessagesTimeline.tsx

💭 That comment sits within a ternary expression so it's valid JS syntax, and I don't see any Effect service violations here.

Agent Credits: 32 credits

Token usage: 6 uncached input · 67,034 cache-read input · 35,526 cache-write input · 1,804 output
Agent Credits may also include non-token charges from external tools such as web research.

View more details on MacroscopeApp