Skip to content

fix(server): avoid slow checkpoint index rebuilds - #8538

Closed
Radu028 wants to merge 1 commit into
pingdotgg:mainfrom
Radu028:fix/checkpoint-temp-index-cleanup
Closed

Radu028 wants to merge 1 commit into
pingdotgg:mainfrom
Radu028:fix/checkpoint-temp-index-cleanup

fix(server): avoid slow checkpoint index rebuilds

4b61437
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Aug 28, 2026 in 42s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — 3 tool calls

💭 I'm checking the diff for GitVcsDriver.ts and its test file to understand the existing conventions before making changes.

1. browse_code — apps/server/src/vcs/GitVcsDriver.ts

2. browse_code — apps/server/src/vcs/GitVcsDriver.ts

💭 I'm checking whether using Node's built-in fs module directly in the test mock violates the service conventions, but since it's confined to a test file rather than production code, it seems reasonably acceptable.

3. browse_code — apps/server/src/vcs/GitVcsDriver.test.ts

💭 The makeVcsDriverShape naming is pre-existing in the repo, not introduced by this PR, so I shouldn't flag it against the convention. I'm now checking the error handling around the empty tree oid case in the production code. I'm scanning for new error classes or convention violations—no new ones introduced, and the use of Effect.ignore and Effect.orElseSucceed swallows failures but doesn't clearly violate the documented error-modeling conventions. I also check for disallowed patterns like Layer.succeed, ManagedRuntime.make, or bare runPromise calls, finding none, and note the test file suppresses a node-builtin-import diagnostic that isn't explicitly covered by the stated conventions. Since the behavior change is accompanied by proper tests and there's no misuse of error-handling combinators like catchIf or catchTag, I conclude there are no real findings. That means the check should report success with something like "All clear" as the title and summary, formatted as the required JSON output rather than literal text.


Agent Credits: 31 credits

Token usage: 6 uncached input · 56,157 cache-read input · 35,245 cache-write input · 1,740 output
Agent Credits may also include non-token charges from external tools such as web research.