Skip to content

fix(shared): stop reporting "not a worktree" when .git cannot be read - #4603

Closed
NoahHendrickson wants to merge 1 commit into
pingdotgg:mainfrom
NoahHendrickson:fix/devhome-silent-fallback
Closed

NoahHendrickson wants to merge 1 commit into
pingdotgg:mainfrom
NoahHendrickson:fix/devhome-silent-fallback

fix(shared): stop reporting "not a worktree" when .git cannot be read

9bb4138
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check completed Jul 27, 2026 in 5m 14s

Not eligible (click on check for details)

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
This PR changes error propagation behavior in git worktree detection functions, converting previously-swallowed errors into surfaced failures. An unresolved review comment identifies a medium-severity concern that explicit --home-dir overrides may be blocked by detection failures. The behavioral change and design concern warrant human review.

Notes:
No code owners found in target merge base a17cbc3