Skip to content

[codex] Sanitize client error log diagnostics - #3405

Merged
juliusmarminge merged 3 commits into
mainfrom
codex/sanitize-client-error-logs
Jun 20, 2026
Merged

juliusmarminge merged 3 commits into
mainfrom
codex/sanitize-client-error-logs

[codex] Sanitize client runtime failure diagnostics (#3411)

b8e22c7
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Jun 20, 2026 in 52s

Effect Service Conventions: All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

This PR sanitizes client error logs by introducing a pure helper module packages/client-runtime/src/errors/safeLog.ts (safeErrorLogAttributes) and routing log call sites through it. It does not create, move, or refactor an Effect service, so the service-definition, error-class, and file-layout conventions are not engaged.

Reviewed changed in-scope files: safeLog.ts (and barrel errors/index.ts), connection/supervisor.ts, state/shell.ts, state/session.ts, state/archivedThreads.ts, plus the web/mobile call sites. Findings:

  • safeLog.ts is a pure helper module; named function exports and named imports of it are correct per the conventions (named imports are appropriate for pure helpers).
  • Effect library modules are imported as namespaces from their subpaths (import * as Effect from "effect/Effect", * as Cause, * as Option, etc.). Named imports from effect/unstable/reactivity are whole-package style and acceptable.
  • Logging refactors use idiomatic Effect.logWarning/logError + Effect.annotateLogs, and Effect.fn constructors are preserved.
  • No Schema.TaggedErrorClass definitions, error predicates, or service tags/layers were added or changed, so error-modeling and predicate conventions do not apply.

No convention violations introduced or retained in the changed scope.


The agent made no additional tool calls beyond your initial Check Run Agent prompt.


Agent Credits: 37 credits