Skip to content

fix(web): the new-thread project picker follows the manual project order - #29846

Open
saphid wants to merge 1 commit into
pingdotgg:mainfrom
saphid:fix/projects2-hunt
Open

saphid wants to merge 1 commit into
pingdotgg:mainfrom
saphid:fix/projects2-hunt

fix(web): the new-thread project picker follows the manual project order

843f9e1
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Nov 3, 2026 in 1m 38s

Approved

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
The new-thread project picker now honors the saved manual project order through the shared sorting hook. This is a limited presentation change that preserves existing settings and project selection behavior.

Additional Thinking

Your Custom Policy

The default criteria apply. The assessed change honors an existing manual-order preference rather than changing product defaults, and adds no diagnostic-suppression directive; neither additional human-review condition is triggered.

Code

The new-thread project picker replaces its local grouping/sorting pipeline with useSortedProjectGroups. That hook applies saved project order only for manual sorting and retains the existing grouping and non-manual sorting pipeline. Active-project selection remains based on its reference. Two ignored files were excluded from assessment as instructed.

Review Context

Author saphid is identified as a contributor; no code-ownership requirement was supplied. The supplied review check reports no unresolved comments or correctness findings, and no blocking severity or check results were supplied. The PR description reports targeted browser verification, including a rebased test run; these reports support the intended scope but were not independently executed.

Verdict

The understood effect is presentation ordering within an existing picker, using an established shared hook. It does not change persisted preferences, project permissions, or draft targeting, and presents no obvious material risk requiring human judgment.

Notes:
No code owners found in target merge base e0f69e9


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.