Skip to content

fix(server): restart notes no longer split an emoji in a long background task label - #29647

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
saphid:fix/restart-note-surrogate
Nov 3, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:mainfrom
saphid:fix/restart-note-surrogate

fix(server): restart notes no longer split an emoji in a long backgro…

d3532ee
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Nov 2, 2026 in 2m 19s

Approved

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Long background-task labels now avoid splitting an emoji when truncated in restart notes. The change is confined to label formatting and preserves existing workflow behavior and length limits.

Additional Thinking

Your Custom Policy

Default approvability criteria apply. The change neither changes product defaults nor adds or broadens static-analysis suppression directives, so neither additional human-review requirement is triggered.

Code

The supplied diff changes only long-label truncation in restart background-work notes: when the cutoff ends on a UTF-16 high surrogate, it removes that code unit before adding an ellipsis. Surrounding code confirms this helper formats task labels, retains existing length bounds and ID handling, and does not change cancellation or continuation policy. The ignored file was not reconstructed.

Review Context

The author is saphid; no ownership requirements were supplied. There are no unresolved review comments or supplied correctness findings. No check results were supplied. The supplied diff and surrounding implementation establish a narrowly bounded text-formatting change.

Verdict

The change is limited to preserving surrogate-pair boundaries in truncated descriptive labels sent in restart notes. Existing label limits and workflow behavior remain unchanged, with no obvious material exposure or product decision requiring human judgment.

Notes:
No code owners found in target merge base 30084f0


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.