Skip to content

fix(scripts): check:changed lints Astro components and runs knip for them - #29573

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
saphid:fix/check-changed-astro
Nov 3, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:mainfrom
saphid:fix/check-changed-astro

fix(scripts): check:changed lints Astro components and runs knip for …

9284b2b
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Nov 2, 2026 in 2m 10s

Approved

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Astro changes now receive lint and trigger knip in check:changed, aligning local validation with CI. The change is confined to developer checks and does not alter product behavior or suppress diagnostics.

Additional Thinking

Your Custom Policy

Default criteria apply. Neither additional human-review condition is triggered: this changes developer check coverage, not product defaults, and broadens diagnostic execution rather than disabling or suppressing diagnostics.

Code

The code-file pattern now includes .astro files. In check:changed this sends existing Astro components to lint, triggers the existing knip passes for Astro changes, and includes adjacent tests in selection. Scope is developer validation, not production runtime or customer data. The ignored test-file diff was not reconstructed.

Review Context

Author is saphid; no ownership requirements were supplied. There are no supplied unresolved review comments or blocking findings. The author reports 15 passing launcher tests and before/after runtime verification. Retrieved checks show successful lint and server tests, with some checks still running; check state does not determine this recommendation.

Verdict

The understood change expands existing local validation to Astro components using existing check commands. Its consequences are additional developer check execution and diagnostics, without material operational effects or a product-policy decision requiring human judgment.

Notes:
No code owners found in target merge base cbd3e14


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.