Skip to content

fix(scripts): check:changed lints Astro components and runs knip for them #29573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 1 commit into from
Nov 3, 2026
Merged

fix(scripts): check:changed lints Astro components and runs knip for them #29573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scripts/check-changed.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,17 @@ it("checks changed source paths through the Windows launcher", () => {
expect(result.stdout).toContain("fixture stderr: lint");
});

it("lints an Astro component and runs knip when only it changed", () => {
using project = launcherFixture();
const page = "packages/example/Page.astro";
project.write(page, "---\nconst title = 1;\n---\n<h1>{title}</h1>\n");
const result = project.run();
expect(result.status, result.stdout + result.stderr).toBe(0);
const calls = project.calls();
expect(calls.find(({ args }) => args[0] === "lint")?.args).toEqual(["lint", page]);
expect(calls.some(({ args }) => args[0] === "exec" && args[1] === "knip")).toBe(true);
});

it.each(["install", "lint"])("reports a failing %s step with its output", (step) => {
using project = launcherFixture();
project.write(project.source, "export const value = 2;\n");
Expand Down
3 changes: 2 additions & 1 deletion scripts/check-changed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ export const comparisonBase = Effect.fn("checkChanged.comparisonBase")(function*
return closest;
});

const CODE = /\.[cm]?[jt]sx?$/;
// CI's lint and knip also read Astro components' frontmatter.
const CODE = /\.(?:[cm]?[jt]sx?|astro)$/;
const TEST = /\.test\.[cm]?[jt]sx?$/;
// CI runs the .github/scripts tests with `node --test`; vitest passes a failing node:test file.
const NODE_TEST = /^\.github[/\\]scripts[/\\]/;
Expand Down
Loading