Skip to content

fix(opencode): a command that never calls the model no longer leaves the turn running - #27378

Open
juliusmarminge wants to merge 4 commits into
mainfrom
fix/issue-27348
Open

juliusmarminge wants to merge 4 commits into
mainfrom
fix/issue-27348

Merge remote-tracking branch 'origin/main' into fix/issue-27348

bbf95ca
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Oct 30, 2026 in 1m 55s

Approved

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
OpenCode commands that start no model execution now finish their turn instead of leaving it running. Activity and history checks preserve normal execution-event handling, keeping the change narrowly scoped.

Additional Thinking

Your Custom Policy

Default approvability criteria apply. This is a lifecycle correction, not a product-default change, and the assessed diff adds no static-analysis suppression directives; neither additional human-review condition is triggered.

Code

After a registered OpenCode 2 slash command returns, the adapter checks local activity, provider activity, and history since the pre-command boundary. Only an idle turn with no execution history is ended through the existing completion path. Checks have five-second timeouts, failures retain existing behavior, and a lock protects the final activity recheck. Two customer-ignored files were left outside assessment.

Review Context

The author is a repository admin and ping-devs member; no ownership restriction was supplied. No unresolved review comments or correctness findings were supplied. The PR description reports focused regression tests, delayed-event coverage, and real-provider/browser reproductions supporting the intended behavior. No independent CI results were supplied or used.

Verdict

The change is confined to post-command turn settlement and preserves event-driven handling whenever execution activity or history exists. Bounded read-only checks and guarded settlement limit exposure, with no new destructive operation, operational rollout dependency, or material product decision requiring human judgment.

Notes:
No code owners found in target merge base a773dc3


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.