[NathanGlasby]

Problem

Settings → About offers Install when another t3 executable is first on PATH, even though the desktop service rejects installation in that state. Clicking it produces an error the UI already has enough information to prevent.

Change

Disable Install while another t3 blocks installation. Keep the existing PATH explanation and allow Remove when T3 Code's own launcher is installed but shadowed.

Scope and approval

Fixes #27093. This qualifies for the very small, focused obvious-bug exception: the existing desktop-only control now reflects the backend's established installation restriction.

Verification

• The browser regression fails on the original code because Install remains enabled. With the fix, it verifies blocked Install, enabled Install after the conflict clears (including an off-PATH destination), and usable Remove for an installed-but-shadowed launcher.
• vp test run apps/web/src/components/settings/CliCommandSettingsRow.browser.test.tsx: passed.
• vp run check:changed after rebasing onto cba30591f958: formatting, lint, both Knip passes, affected typechecks, the browser regression, and React Compiler verification passed.
• Captured the actual About settings UI in the isolated dev app with a synthetic desktop CLI bridge. A temporary visibility fixture exposed the desktop-only section in the browser and was removed after capture. Packaged Electron and real filesystem installation/removal were not exercised.

Before	After

Implemented with GPT-6.1-Sol through the Codex harness in T3 Code.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-30T00:40:32.551797Z We couldn’t complete this review. Comment @codex review to try again.	2815f1f	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[macroscopeapp]

Approvability

Verdict: Approved at 2815f1f

Macroscope's review found this PR approvable — The Install button now reflects the existing backend restriction when another t3 executable takes precedence on PATH. Removal remains available, and installation behavior and product defaults are unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: d2d1e4f
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: bf13ef5f-623b-4e2e-98c2-19a30cb8fc6c

Commits

Reviewing files that changed from the base of the PR and between 2815f1f and 39cfffe.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

The CLI settings row now disables installation when another t3 shadows the command. It keeps the button enabled for removal when the command is installed. A browser test covers these states.

Changes: CLI install control

Layer / File(s)	Summary
Shadowed install button state apps/web/src/components/settings/CliCommandSettingsRow.tsx, apps/web/src/components/settings/CliCommandSettingsRow.browser.test.tsx	The row disables Install when the command is not installed and another t3 shadows it. The browser test checks that Install is enabled after shadowing clears and that an installed command can still be removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

• pingdotgg/t3code#25417: Adds the desktop CLI installation and shadow-detection state that this change uses.
• pingdotgg/t3code#22375: Changes how the desktop CLI identifies its own launcher when detecting shadowing.
• pingdotgg/t3code#22046: Changes which PATH entries count when determining the shadowing state.

Suggested labels: bugfix, size:S

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · previous review 2815f

The change preserves removal while preventing blocked installations. No merge-blocking issue was identified.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "fix(desktop): disable blocked t3 CLI installation" matches the main change. The raw summary shows the CLI command button is now disabled when installation is not active and state.shadowedBy…
Description check		The description follows the template's main sections. Problem explains that Settings offers Install when another t3 executable is first on PATH, and the desktop service rejects that install. Change ex…
Linked Issues check		Issue #27093 requires the Settings row to prevent a failing Install action when another t3 is reported by shadowedBy, while retaining the existing explanation and allowing removal of T3 Code's ins…
Out of Scope Changes check		The pull request changes only CliCommandSettingsRow.tsx and its focused browser test. The component change implements issue #27093 directly. The test verifies the required UI states and the Remove a…

Full details: Title check

Explanation

The title "fix(desktop): disable blocked t3 CLI installation" matches the main change. The raw summary shows the CLI command button is now disabled when installation is not active and state.shadowedBy is set. The PR objectives say Install is disabled when another t3 executable blocks installation, and Remove stays available for an installed but shadowed launcher. The title is concise, follows conventional commit form, and names the scope (desktop) and the action (disable blocked installation).

Full details: Description check

Explanation

The description follows the template's main sections. Problem explains that Settings offers Install when another t3 executable is first on PATH, and the desktop service rejects that install. Change explains the disabled Install state and the preserved Remove action for a shadowed launcher. Scope and approval links issue #27093 and explains why the small obvious-bug exception applies. Verification lists the browser regression test, the vp test run command with its pass result, the check:changed results, and before/after screenshots. It also states what was not checked: packaged Electron and real filesystem installation and removal. The template asks for a model and harness line at the end, and the author included one. Two gaps remain. The before/after screenshots link to a GitHub release on a fork, so reviewers may not be able to confirm the assets resolve. The Scope section cites the exception without a maintainer approval comment, which the template also mentions for issues that are not very small. Overall the description is mostly complete.

Full details: Linked Issues check

Explanation

Issue #27093 requires the Settings row to prevent a failing Install action when another t3 is reported by shadowedBy, while retaining the existing explanation and allowing removal of T3 Code's installed launcher. CliCommandSettingsRow.tsx now disables the button only when !installed and state.shadowedBy is set. The existing shadowedBy description remains unchanged. The browser test covers blocked Install, enabled Install after the conflict clears with an off-PATH destination, and enabled Remove when an installed launcher is shadowed.

Full details: Out of Scope Changes check

Explanation

The pull request changes only CliCommandSettingsRow.tsx and its focused browser test. The component change implements issue #27093 directly. The test verifies the required UI states and the Remove action. No unrelated product behavior or unrelated files are changed.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[NathanGlasby]

Note

🤖 GPT-6.1-Sol responding on behalf of NathanGlasby

@codex review

The initial review could not complete. Please retry on the current head.

[chatgpt-codex-connector]

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

kept NathanGlasby's one-line guard and focused regression unchanged. merged current main into the original branch without rewriting history. no extra production code was needed: blocked install is disabled, while remove stays available for an installed but shadowed launcher.

verification at 39cfffe6064fffaa3d042128d3a833ed216a7762:

• reproduced the regression without the guard: the blocked install assertion fails.
• blacksmith: 10 focused browser, state, and desktop service tests passed. vp run check:changed github/main passed formatting, lint, both knip passes, affected typechecks, browser regression, and react compiler verification.
• chrome: matching about captures and install/remove interaction passed using the real app components with a synthetic desktop cli bridge and temporary browser-only visibility overrides. no fixture changes remain.
• 29 ci checks passed; two independent code reviews approved this head. no actionable bot findings remain. the old codex review failed to run; it was not retriggered.

unverified: packaged electron and actual filesystem install/removal. known limit for NathanGlasby: external PATH changes require reopening settings after its 30-second stale period or reloading; automatic refocus refresh is a separate follow-up. this desktop-only control does not change web/mobile, providers, or connection protocols.