Skip to content

fix(web): keep retention controls stable while editing days #26335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0bkevin wants to merge 7 commits into
base: main
Choose a base branch
from
+180 −42
Open

fix(web): keep retention controls stable while editing days #26335

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
96aabaa
fix(web): keep retention controls stable while editing days
0bkevin Oct 28, 2026
77ed8fe
fix(web): keep retention status stable while saves settle
0bkevin Oct 28, 2026
df8ff3f
fix(web): remove empty retention status space
0bkevin Oct 28, 2026
27b85d2
Merge branch 'main' into fix/26327-retention-controls-stability
0bkevin Oct 28, 2026
08c0051
fix(web): keep retention changes limited to layout
0bkevin Oct 28, 2026
0facba1
fix(web): stabilize transient retention status changes
0bkevin Oct 28, 2026
0eb84d1
Merge branch 'main' into fix/26327-retention-controls-stability
0bkevin Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions apps/web/src/components/settings/StorageSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ function RetentionControl({
<NumberFieldDecrement aria-label={`Decrease ${label}`} />
<NumberFieldInput
aria-label={`${label} in days`}
size={new Intl.NumberFormat().format(draft ?? value).length}
className="field-sizing-content w-auto min-w-[1ch] grow-0 text-right"
size={5}
className="w-auto grow-0 text-right"
/>
<span aria-hidden="true" className="self-center pr-2 text-xs">
days
Expand Down Expand Up @@ -696,10 +696,15 @@ export function StorageCleanupSections() {
const updateSettings = useUpdateScopedSettings();
if (scope.kind === "project" || scope.kind === "checkout") return null;
const settings = scopedSettings.storageCleanup;
const ruleStatus = (key: "browserArtifactsAfterDays" | "logsAfterDays") =>
targets.some((target) => target.settings.storageCleanup[key] !== settings[key])
? "Mixed across selected machines"
: undefined;
const ruleStatus = (key: "browserArtifactsAfterDays" | "logsAfterDays") => {
if (targets.length < 2) return undefined;
const mixed = targets.some((target) => target.settings.storageCleanup[key] !== settings[key]);
return (
<span className={mixed ? undefined : "invisible"} aria-hidden={!mixed}>
Mixed across selected machines
</span>
);
};
const update = (patch: Partial<StorageCleanupSettings>) =>
updateSettings({ storageCleanup: patch });
const databaseStorageNotice = (
Expand Down
Loading