Skip to content

fix(mobile): list bullets keep a gap before their text at every text size #26268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 28, 2026
+15 −4
Merged

fix(mobile): list bullets keep a gap before their text at every text size #26268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions apps/mobile/src/native/EnrichedMarkdownText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
markdownWithTableBreaks,
} from "../lib/markdownDocument";
import { isValidElement, useMemo, useState, type ReactNode } from "react";
import { Platform, Share, StyleSheet, View } from "react-native";
import { Platform, Share, StyleSheet, useWindowDimensions, View } from "react-native";
import {
EnrichedMarkdownText,
type MarkdownImageBlock,
Expand All @@ -35,6 +35,7 @@ import {
function enrichedStyle(
style: SelectableMarkdownTextProps["textStyle"],
dark: boolean,
fontScale: number,
): MarkdownStyle {
const monospace = Platform.OS === "ios" ? "Menlo" : "monospace";
// Keep the radius modest: iOS clips square table-cell borders without stroking the corner arcs.
Expand Down Expand Up @@ -132,7 +133,13 @@ function enrichedStyle(
borderWidth: 2,
gapWidth: 12,
},
list: { ...body, bulletColor: style.mutedColor, markerColor: style.mutedColor, gapWidth: 6 },
list: {
...body,
bulletColor: style.mutedColor,
markerColor: style.mutedColor,
// The bullet is centred on the gap's edge and scales with the system text size; the gap must too.
gapWidth: 12 * fontScale,
},
thematicBreak: { color: style.dividerColor, height: 1, marginTop: 8, marginBottom: 8 },
table: {
...body,
Expand Down Expand Up @@ -256,9 +263,13 @@ export function MobileEnrichedMarkdownText(props: SelectableMarkdownTextProps) {
mimeTypes: { "app.t3.context-fragment": props.contextClipboardFragment! },
};
}, [props.contextClipboardFragment, props.markdown]);
const { fontScale } = useWindowDimensions();
const markdownStyle = useMemo(
() => ({ ...enrichedStyle(props.textStyle, themeAppearance === "dark"), linkVariants }),
[props.textStyle, themeAppearance, linkVariants],
() => ({
...enrichedStyle(props.textStyle, themeAppearance === "dark", fontScale),
linkVariants,
}),
[props.textStyle, themeAppearance, fontScale, linkVariants],
);
const renderers = renderImage
? {
Expand Down
Loading