Repository navigation
fix(mobile): list bullets keep a gap before their text at every text size - #26268
Merged
Merged
Conversation
…size Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Mobile markdown lists gain wider spacing that scales with system text size. The change is confined to presentation, with no persistent-data or external-system effects. You can add or adjust custom eligibility rules. Learn more. |
19 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In assistant messages, a list bullet sat almost against its text ("•Moonbase"), and touched it at large text sizes. Our list style set a 6 pt gap, half the markdown library's default. The bullet is drawn centred on the gap's edge, so only about 3 pt showed. The bullet grows with the system text size and the gap did not, so at the largest sizes the bullet closed it.
The gap is now the library's default 12 pt, scaled by the system text size (
useWindowDimensions().fontScale), so bullet and text keep the same spacing at every size.Full screens from
vp run mobile:e2eon the Simlock pool, before (left) and after (right).Pixel 10 Pro, largest text:
iPad Pro 13", landscape, largest text:
iPhone SE, default text size:
Pixel Tablet, default text size:
🤖 Generated with Claude Code — Claude Opus 5.5