[juliusmarminge]

Problem

useWorktreeSetup copied each new worktree-setup snapshot into held state from an effect after commit. Its caller, LiveThreadRouteController, is the route-level controller for the whole mobile thread screen, so every setup progress update committed the thread route twice.

Change

The hook now adjusts held during render (if (snapshot && snapshot !== live) setHeld(...)), the same pattern ThreadFeed.tsx and WorkspaceTabsContext.tsx already use. React re-runs the hook before committing. On that pass resolveWorktreeSetupSnapshot returns the held object by identity, so snapshot === live and the update settles. When setup stops running, the query switches to null and the held snapshot keeps showing, as it did before.

What this improves

• Renders avoided: one commit of the thread route subtree per worktree-setup emission while a new worktree is being prepared.
• Sync removed: the post-commit copy effect and its react/set-state-in-effect lint disable.
• No behavior change: the snapshot shown and when the subscription stops are the same as before, one commit earlier. No logging changes.

Effects

• apps/mobile/src/features/threads/use-worktree-setup.ts: 1 -> 0

Verification

• vp test run apps/mobile/src/features/threads/worktree-setup-state.test.ts: 4 passed
• vp run check:changed: format, lint, knip (2/2), typecheck (2 packages), and tests all pass

No regression test: this fixes no bug. It saves a commit, and mobile has no hook-render test harness that could count commits.

Model: Claude Opus 5.5, Claude Code harness.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 8d2261e

Macroscope's review found this PR approvable — This is a small, self-contained mobile performance refactor that preserves worktree setup state and visible behavior while eliminating a redundant thread-screen commit. It introduces no new capability, product-default change, schema change, or broadened static-analysis suppression.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: effect/split-a2-mobile-worktree-setup-held
• File: .coderabbit.config.ts
• Commit: 8d2261e
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 993e0dec-fa6b-4623-adc6-4a30597d6e40

Commits

Reviewing files that changed from the base of the PR and between 79f6cd3 and 8d2261e.

Files selected for processing: 1

• apps/mobile/src/features/threads/use-worktree-setup.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Walkthrough

useWorktreeSetup now updates held snapshot state during render when a snapshot exists and differs by identity from the live snapshot. It no longer uses useEffect for this retention.

Changes: Snapshot retention

Layer / File(s)	Summary
Render-time snapshot retention apps/mobile/src/features/threads/use-worktree-setup.ts	The hook removes useEffect and updates held snapshot state during render when a snapshot exists and differs by identity from the live snapshot.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related PRs

• pingdotgg/t3code#21098: Changes the same hook’s worktree-fork preparation state and passes fork preparation into useWorktreeSetup.
• pingdotgg/t3code#25119: Adds a lint suppression for the effect that this change removes.

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to 8d226

No actionable merge-blocking risk remains in the reviewed change.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description follows the template. It has Problem, Change, and Verification sections with concrete content. The Scope and approval section is missing. The PR description does not link a triaged bug…	Add a Scope and approval section. Link the triaged issue or the maintainer discussion with the approval comment. If no prior issue exists, explain why this small, focused perf fix qualifies without prior approval. Optionally, state the tool…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title names the main change: a perf fix in the mobile worktree setup hook that avoids an extra thread-screen commit. It uses the conventional commit format and matches the raw summary and PR objec…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: a perf fix in the mobile worktree setup hook that avoids an extra thread-screen commit. It uses the conventional commit format and matches the raw summary and PR objectives, which describe moving the held snapshot update into render.

Full details: Description check

Explanation

The description follows the template. It has Problem, Change, and Verification sections with concrete content. The Scope and approval section is missing. The PR description does not link a triaged bug issue or maintainer approval, and it does not explain why the change qualifies as a small, focused fix without prior approval. The template calls for that section, and the author does not address it. The description also states that no regression test was added, and gives a reason. The template asks for before/after evidence only for UI changes, which this change does not include.

Resolution

Add a Scope and approval section. Link the triaged issue or the maintainer discussion with the approval comment. If no prior issue exists, explain why this small, focused perf fix qualifies without prior approval. Optionally, state the tooling used for verification with the model and harness, which the template also requests at the end of the Verification section.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}