Repository navigation
Conversation
- remove the shared outline cutout from the host and main input surfaces
c644125 to
9d6dd89
Compare
|
Note Written by thanks @dr-baker. removing the shared outline cutout fixes the border without changing the glass material. i preserved your commit and merged current main into the branch. the resulting diff is still exactly five deleted lines in verification: blacksmith passed unverified: native desktop shell, custom themes, and an attached update notice/model-strip transition in the live client. native mobile uses a separate composer and is unaffected. no provider or wire behavior changed. ci status will be checked before handoff. before, light: after, light: before, dark: after, dark: |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Remove context-seam clipping apps/web/src/components/chat/ComposerSurface.tsx |
Host and Main no longer apply the context-seam clipping class. The shared class constant was removed. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related PRs
- pingdotgg/t3code#24837: Changes context-strip geometry and corner treatment in
ComposerSurface. - pingdotgg/t3code#25316: Changes layered composer edges and seam background classes in
ComposerSurface. - pingdotgg/t3code#25401: Changes composer banner surfaces and attached-control presentation.
Suggested reviewers: macroscopeapp
Merge Risk: 
Minimal · up to e4248
-
The composer outline change is mergeable after normal checks; no actionable issue is identified.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title names the main change: it removes the composer outline cutout so the border stays continuous above attached controls. It uses the conventional commit format and matches the five-line removal in ComposerSurface.tsx. Its scope is narrow and accurate, and it does not describe unrelated work.
Full details: Description check
-
Explanation
The description includes all required sections. It explains the problem, change, scope and approval basis, verification results, visual evidence, and unverified checks. It also identifies the model and harness used.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
thanks mariastra. repro looks great |
|
Note Written by Verified in a real dev environmentverified as-is at reproduced the missing bottom outline on on main the attached host outline clips out its middle two pixels. on this head the outline continues across the input in light and dark. both screenshot pairs use the same project path, prompt, model, and 1280×800 viewport. main is newer than the pr, so unrelated model-label and sidebar presentation differs. also exercised a real branch mismatch notice with lower context controls enabled through settings. the host outline hides and the main input outline draws without clipping. clicking "restore branch" changed the real checkout back and removed the notice. real sol follow-ups completed; the project actions menu opens, the composer draft survives reload, and the 390px web layout has no horizontal overflow. blacksmith passed the uploaded clip plays and seeks in t3's browser player. github and git.cafe do not embed this external mp4 inline. Not verifiednative electron on macos/windows, native ios/android, other browsers/providers, custom themes, remote relay/tunnel connections, an actual update notice, and the model-strip collapse transition. the branch notice exercises the shared attached-banner outline but does not prove the update-specific flow. native mobile uses a separate composer. no claim about merge readiness against newer main. |









Problem
When the lower controls attach to the composer, a clip path removes the middle of the composer's bottom outline. The border ends at the attachment edges instead of continuing across the input. This addresses the outline portion of the original report.
Change
Remove the outline cutout from both the host outline and the main input outline. The host draws the outline normally; the main input draws it when an upper banner is attached or the lower controls are transitioning.
Scope and approval
Five deleted lines in one component. This is a focused visual defect fix covered by the obvious-bug exception. Web and desktop use the same composer component. The existing material rendering remains unchanged; #25335 already fixed the missing lower-card background under update notices.
Verification
vp run check:changed bfc7177passed formatting, lint, both Knip checks, and typechecking of affected packages. No tests were added for this visual-only change.Verified the exact narrowed patch in T3's Browser panel against isolated, populated development state. Before is
bfc7177; after is9d6dd892ed. Each pair uses the same 1280×800 viewport, timeline position, and composer state. The dark pair has an attached upper banner; the light pair exercises the host outline without a banner. The update notice is a temporary fixture rendered with the real banner components; timeline text is sanitized. No fixture code is included in the PR.The dark-mode crops differ only on the restored bottom border row. The strip background and backdrop filter are unchanged. The 8× detail uses nearest-neighbor scaling so the one-pixel outline is visible.
Scrolling verification on the narrowed patch
Model: GPT-6.1-Sol. Harness: Codex in T3 Code.