fix(web): keybindings page says to connect an environment when none is connected

[t3dotgg]

Problem

On app.t3.codes, Settings → Keybindings looked editable, but Save did nothing and showed no message (#11448). #9786 has since locked the editor when no environment is connected. But the notice it shows in that state is "This connection can view keybindings but cannot change them." That points to a permission problem, when the real cause is that no environment is connected.

Change

When no environment is connected, the notice now says "Connect an environment to change keybindings." This is the same copy that other server settings use. When an environment is connected but does not have settings:write, the notice still names the permission. Write logic does not change. Saves still go through the permission-checked server.upsertKeybinding / server.removeKeybinding RPCs.

Web and desktop share this panel. Mobile has no keybindings editor.

Scope and approval

This is a triaged bug with the accepted label. The triage comment asks to "disable Save and show the same reconnect / hosted-app copy other server settings use" when connectedEnvironments.length === 0. #9786 did the disable step. This PR adds the copy. #11483 tried the same fix but was closed during the cleanup of PRs from older models. It was not closed on its merits.

Verification

• New test in KeybindingsSettings.environment.test.tsx renders the panel with no connected environment and checks the notice. Before the fix it failed and received the permission copy. After the fix it passes. A second test checks that the permission copy is kept for a connected environment that cannot write settings.
• vp test run on KeybindingsSettings.environment.test.tsx and KeybindingsSettings.logic.test.ts: 31/31 pass.
• vp lint, vp fmt --check on the touched files, and apps/web tsc --noEmit: clean.
• Not done: I did not run a browser check or take screenshots. This change replaces one sentence of text. Nothing else in the layout changes.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol (approved, no findings).

Refs #11448

Model and harness: Claude Opus 5.5 in Claude Code via T3 Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 7dee1e2

Macroscope's review found this PR approvable — This narrowly scoped fix changes only the keybindings notice for the existing no-environment state and preserves the permission message for connected environments. Tests cover both branches, with no schema, deployment, security, or configuration impact.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 1d2e5233-a524-4853-9a7b-0ca8b4fdfdef

📥 Commits

Reviewing files that changed from the base of the PR and between 2cde3f7 and 7dee1e2.

📒 Files selected for processing: 2

• apps/web/src/components/settings/KeybindingsSettings.environment.test.tsx
• apps/web/src/components/settings/KeybindingsSettings.tsx

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

The keybindings settings panel now prompts users to connect an environment when none is connected. When an environment is connected but lacks settings-write permission, the panel retains its view-only notice. Tests cover both conditions.

Changes: Keybindings environment notices

Layer / File(s)	Summary
Show the notice for the environment state apps/web/src/components/settings/KeybindingsSettings.tsx, apps/web/src/components/settings/KeybindingsSettings.environment.test.tsx	The panel shows “Connect an environment to change keybindings.” when no environment is connected. It retains the view-only notice when the connection lacks settings-write permission. Tests cover both cases.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 7dee1

The notice now explains that users need to connect an environment to change keybindings, while preserving the view-only message for connections without write access. No material merge blocker is evident.

Pre-merge checks: 4

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		Issue #11448 requires either a successful keybinding update or feedback that explains why the save cannot proceed. This change provides the required feedback for the no-environment state: `Keybindings…
Out of Scope Changes check		The source change only selects the correct notice for the connection state. The added test state and two notice tests verify the issue behavior and preserve the permission case. These changes directly…
Title check		The title clearly and concisely describes the main change: correcting the Keybindings notice when no environment is connected.
Description check		The description covers the problem, change, scope and approval, verification results, limitations, and testing details. It notes that browser verification and screenshots were not completed, but the r…

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	4.9 KiB	−23 B (−0.5%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	−23 B (−1.9%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.8 KiB	−41 B (−0.2%)	29.3 KiB	✅
Codex	Live turn messages	2	1	−1 (−50.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	+7 B (+0.1%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+7 B (+0.6%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	0 B (0.0%)	29.3 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: 2cde3f7 · PR result: 7dee1e2 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.