Skip to content

fix(server): Claude thinking before a tool call stays a collapsed Thought - #18887

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:fix/claude-thinking-stays-reasoning
Oct 13, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:fix/claude-thinking-stays-reasoning

fix(server): Claude thinking before a tool call stays a collapsed Tho…

d1e02cc
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Oct 13, 2026 in 1m 57s

All clear

All clear

Details

Warning

  • Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed all 1 changed files (no prior completed review)


🔍 Agent activity — 11 tool calls

1. browse_code — apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts

2. browse_code — apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts

3. browse_code — apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts

4. browse_code — apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts

5. browse_code — apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts

6. browse_code — In apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts identify whether the changed snapshot thinking loop and removal of lastThinking promotion introduce any Effect service conventions violation; focus on changed lines and focused regression test coverage. Answer briefly.

7. browse_code — Check apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts lines 2812-2875: do assertions cover changed behavior of multiple thinking snapshots followed by tool use, for four model names? Brief answer.

8. browse_code — Does that test use test layers for external services rather than mocking core business logic? Briefly.

9. browse_code — Are there any changed imports, service definitions, runtime boundaries, error definitions or lint directives in this PR's ClaudeAdapterV2.ts diff? Reply yes/no with concise rationale.

10. browse_code — Summarize whether any changed production lines are in transport handlers or introduce new exported free effectful function. One sentence.

11. browse_code — Confirm concise verdict for Effect Service Conventions on this change, considering regression test. One sentence.


Agent Credits: 34 credits

Token usage: 114 uncached input · 778,527 cache-read input · 52,331 cache-write input · 3,383 output
Agent Credits may also include non-token charges from external tools such as web research.