fix(web): Git actions follow the selected thread

[Yash-Singh1]

Problem

After switching threads, the details panel can show the new checkout while Commit, push & PR operates on the first checkout. Progress and error toasts also target the first thread, making the visible button appear to do nothing.

The memo wrapper added in #18077 exposes React 19.2's stale useEffectEvent behavior inside memoized components. The issue is tracked upstream in react/react#34818.

Change

Replace the Git action Effect Event with a dependency-aware useCallback, keeping the panel memoized. Each rendered button uses its current checkout and thread; retained toast actions keep the checkout and thread that produced them. Update the existing permission tests and add real React lifecycle coverage using the same memo wrapper as the details panel.

Scope and approval

This is a focused correction of a reproduced Git action bug. It changes no UI appearance, contracts, provider adapters, or server behavior.

Verification

• Reproduced in installed Nightly: clicking the styling thread's button sent a Git request to the Claude Stop worktree.
• Before the fix, the memoized navigation regression fails: after switching to /second, the action sends cwd: /first and threadId: first. With the fix, it passes through first → second → first navigation.
• vp test run apps/web/src/components/GitActionsControl.lifecycle.test.ts apps/web/src/components/GitActionsControl.test.ts apps/web/src/components/GitActionsControl.logic.test.ts apps/web/src/state/sourceControlActions.test.ts packages/client-runtime/src/state/vcsAction.test.ts: 117 tests passed across 5 suites.
• vp run --filter @t3tools/web typecheck: passed.
• Scoped vp lint on the 3 changed files: passed, with one existing react(memo-dependencies) warning at GitActionsControl.tsx:612.
• Scoped vp fmt --check and git diff --check: passed.

Made with GPT-6.1-Sol through the Codex harness in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 76a7487

Macroscope's review found this PR approvable — This is a focused, self-contained fix to existing Git action context handling in a memoized web panel. The added lifecycle coverage verifies both current-thread actions and retained toast actions without introducing schema, infrastructure, default, or static-analysis changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 03c9e66e-dd79-4288-bef1-364d28da3d44

📥 Commits

Reviewing files that changed from the base of the PR and between ffb4af8 and 76a7487.

📒 Files selected for processing (3)

• apps/web/src/components/GitActionsControl.lifecycle.test.ts
• apps/web/src/components/GitActionsControl.test.ts
• apps/web/src/components/GitActionsControl.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

Walkthrough

GitActionsControl now binds its Git action handler with useCallback. Lifecycle tests verify how retained toast actions and quick-action buttons use thread and working-directory values across navigation.

Changes

Git action lifecycle

Layer / File(s)	Summary
Bind the handler to render state apps/web/src/components/GitActionsControl.tsx	GitActionsControl replaces useEffectEvent with useCallback and lists the captured state and functions as dependencies.
Verify action behavior across navigation apps/web/src/components/GitActionsControl.test.ts, apps/web/src/components/GitActionsControl.lifecycle.test.ts	The mock records useCallback handlers. Lifecycle tests check retained toast actions against the originating thread and working directory, and quick actions against the current values.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 76a74

No identified issue prevents merging after normal checks.

Pre-merge checks · 4

Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main fix: Git actions now follow the selected thread.
Description check		The description covers the problem, change, scope, approval rationale, and detailed verification results. It also identifies the affected React behavior and lists the relevant tests and checks.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.9 KiB	0 B (0.0%)	29.3 KiB	✅
Codex	Live turn messages	2	2	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	0 B (0.0%)	29.3 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: ffb4af8 · PR result: 76a7487 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.