Repository navigation
fix(mobile): keep Android markdown icons aligned with text - #11079
Merged
shivamhwp merged 2 commits intoSep 10, 2026
Merged
MacroscopeApp / Macroscope - Correctness Check
succeeded
Sep 10, 2026 in 20m 29s
No issues identified (6 code objects reviewed).
• Reviewed files modified since
8e520d3; other PR files not modified since then were skipped.
• Merge Base:d29c56a
• Head:66e9443
Details
| ✅ | File Path | U3 Bytes | Comments Posted | Reason |
|---|---|---|---|---|
| ➖ | apps/mobile/src/lib/nativeMarkdownText.test.ts |
591 | Excluded by default ignore patterns | |
| ✅ | apps/mobile/modules/t3-markdown-text/android/build.gradle |
653 | 0 | |
| ➖ | apps/mobile/modules/t3-markdown-text/android/src/test/java/expo/modules/t3markdowntext/MarkdownSelectionCopyTest.kt |
1747 | Excluded by default ignore patterns | |
| ✅ | apps/mobile/modules/t3-markdown-text/src/nativeMarkdownText.ts |
826 | 0 | |
| ✅ | apps/mobile/modules/t3-markdown-text/src/NativeMarkdownBlock.ios.tsx |
1686 | 0 | |
| ✅ | apps/mobile/modules/t3-markdown-text/android/src/main/java/expo/modules/t3markdowntext/T3MarkdownTextSelectionModule.kt |
1114 | 0 |
Billed Total: 10.00KB of diff | $0.50 (This review was charged at our per-review byte minimum of 10.00KB. Learn more here)
Filtered Issues Details
apps/mobile/modules/t3-markdown-text/src/NativeMarkdownBlock.ios.tsx
- line 615: Wrapping each document child in a separate
NativeMarkdownBlockcauses every paragraph/heading to retain the terminal"\n"emitted bynativeMarkdownDocumentRuns. On Android this is anRNText/TextView; Android'sStaticLayoutexplicitly appends an empty line when the final character is a newline. Consequently a document with two ordinary paragraphs now has a full blank text line at the bottom of the first block (and of every subsequent block) in addition to the newpaddingTop, producing substantially oversized inter-block gaps rather than the intended 12px/heading spacing. [ Already posted ]
Loading