fix(web): open pull request markdown links in the panel

[juliusmarminge]

Pull request links in PR descriptions, comments, and editor previews could leave the current panel, and code review comments lost the surrounding chat thread. They now use chat's PR link handler with the correct panel and environment. The PR page keeps its URL selection in sync without resetting list filters; Cmd/Ctrl-click keeps the external-browser behavior.

Verified with 93 focused tests and the web typecheck. The new regression fails on the original code because the panel remains empty, then passes with this change. Targeted lint and React Doctor report only existing warnings. Web and desktop share this renderer; mobile has no PR detail panel.

Browser interaction evidence is being collected.

Implemented with GPT-6 in Codex.

Note

Open pull request markdown links in the panel instead of navigating away

• PullRequestMarkdownContext changes from a nullable repository URL string to an object carrying both the repository URL and an optional thread reference, so nested markdown knows which panel it lives in
• ChatMarkdown gains an optional pullRequestPanelRef prop and passes the active environment ID when resolving change-request links, letting links from environment-owned markdown select the matching project
• useOpenChangeRequestLink resolves the panel reference independently from the thread; when a thread exists, links open in that panel, and standalone opens navigate the pull-requests route with preserved list filters and resolved project/environment
• Risk: PullRequestMarkdownContext consumers that read the context value as a plain string will break — they must now read .repositoryUrl off the context object

^{Macroscope summarized b9d8dc9.}

Summary by CodeRabbit

• New Features

  • Pull-request links now open in the appropriate pull-request panel and navigate to the relevant page.
  • Links opened from previews preserve the current thread and code-comment context.
  • Pull-request navigation now remains synchronized across environments and selections.

• Bug Fixes

  • Improved handling of bare pull-request references and unavailable repositories.
  • Modified-click behavior continues to use the browser’s standard handling.

• Tests

  • Added coverage for pull-request link navigation, context inheritance, validation, and click behavior.

[macroscopeapp]

Approvability

Verdict: Approved at b9d8dc9

Macroscope's review found this PR approvable — This is a focused four-file web bug fix that connects existing pull-request markdown links to the appropriate existing panel while preserving environment selection, filters, and external modifier-click behavior. Its runtime impact is localized to link navigation and does not alter schemas, product defaults, deployment, or sensitive code.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[macroscopeapp]

All clear

^{Posted via Macroscope — Effect Service Conventions}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: b30a3e4e-ddcf-4024-bf64-cc491f807090

📥 Commits

Reviewing files that changed from the base of the PR and between e0e0bcb and 3fd3fac.

📒 Files selected for processing (5)

• apps/web/src/components/ChatMarkdown.tsx
• apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx
• apps/web/src/components/pullRequest/PullRequestMarkdown.links.test.tsx
• apps/web/src/components/pullRequest/PullRequestMarkdown.tsx
• apps/web/src/lib/openPullRequestLink.ts

Included review availability: 6 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

---

📝 Walkthrough

Walkthrough

Pull-request markdown now carries repository and thread context into ChatMarkdown. Link handling accepts an explicit panel reference, applies environment-aware navigation, and preserves existing click behavior. Tests cover panel routing, thread inheritance, reference resolution, and unavailable repositories.

Changes

Pull-request link routing

Layer / File(s)	Summary
Markdown context wiring apps/web/src/components/pullRequest/PullRequestMarkdown.tsx, apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx, apps/web/src/components/ChatMarkdown.tsx	The markdown context now includes repositoryUrl and threadRef. ChatMarkdown accepts and forwards pullRequestPanelRef.
Panel-aware link opening apps/web/src/lib/openPullRequestLink.ts, apps/web/src/components/ChatMarkdown.tsx	Change-request links prefer the supplied panel reference, apply cross-environment settings, and navigate standalone openings with pull-request selections.
Link behavior validation apps/web/src/components/pullRequest/PullRequestMarkdown.links.test.tsx	Tests cover panel opening, thread inheritance, bare reference resolution, modifier clicks, and unavailable repositories.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to 3fd3f

Pull-request links now route to the appropriate panel while preserving thread context, environment selection, list filters, and modified-click browser behavior. No concrete merge-blocking risk remains.

Suggested reviewers: maria-rcks, bil0000, t3dotgg

Sequence Diagram(s)

sequenceDiagram
  participant PullRequestMarkdown
  participant ChatMarkdown
  participant useOpenChangeRequestLink
  participant PullRequestPanel
  PullRequestMarkdown->>ChatMarkdown: provide resolved threadRef and panelRef
  ChatMarkdown->>useOpenChangeRequestLink: handle change-request link
  useOpenChangeRequestLink->>PullRequestPanel: open pull request with environment and selection filters

Loading

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary change: opening pull request markdown links in the panel.
Description check	✅ Passed	The description is detailed and directly covers the change, motivation, verification, interaction behavior, and platform scope. It does not use the template headings or include completed UI evidence a…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch open-pr-links-in-panel

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.6 KiB	+61 B (+0.4%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.6 KiB	+57 B (+0.9%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.1 KiB	+88 B (+0.2%)	66.4 KiB	✅
Codex	Live turn messages	8	10	+2 (+25.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.6 KiB	+46 B (+0.3%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+42 B (+0.6%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.9 KiB	+88 B (+0.1%)	66.4 KiB	✅
Claude	Live turn messages	8	10	+2 (+25.0%)	21	✅

Baseline: e0e0bcb · PR result: b9d8dc9 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.9 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

All clear

^{Posted via Macroscope — Effect Service Conventions}