Skip to content

region scatter client: retry scatter regions when finished percentage is not 100.#64884

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
Leavrth:addFailedRegionIDPick
Dec 5, 2025
Merged

region scatter client: retry scatter regions when finished percentage is not 100.#64884
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
Leavrth:addFailedRegionIDPick

Conversation

@Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Dec 5, 2025

This PR is cherry-picked from #60315

What problem does this PR solve?

Issue Number: ref #60077

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Dec 5, 2025
@tiprow
Copy link

tiprow bot commented Dec 5, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.7031%. Comparing base (de5c553) to head (9f3a153).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64884        +/-   ##
================================================
+ Coverage   74.6926%   74.7031%   +0.0105%     
================================================
  Files          1891       1891                
  Lines        515988     515982         -6     
================================================
+ Hits         385405     385455        +50     
+ Misses       106747     106687        -60     
- Partials      23836      23840         +4     
Flag Coverage Δ
integration 48.1156% <63.1578%> (-0.0481%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 62.8272% <63.1578%> (+0.1489%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-05 11:35:26.37221432 +0000 UTC m=+608871.185991893: ☑️ agreed by GMHDBJD.
  • 2025-12-05 12:26:41.132687012 +0000 UTC m=+611945.946464584: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit bc50e0d into pingcap:master Dec 5, 2025
33 of 35 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 5, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #64885.
But this PR has conflicts, please resolve them!

Leavrth added a commit to Leavrth/tidb that referenced this pull request Dec 5, 2025
@Leavrth Leavrth added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 12, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #65000.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 12, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants