-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: remove the same projection when to InjectExtraProjection | tidb-test=pr/2349 #54163
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54163 +/- ##
=================================================
- Coverage 74.9123% 55.9486% -18.9637%
=================================================
Files 1520 1644 +124
Lines 360958 621048 +260090
=================================================
+ Hits 270402 347468 +77066
- Misses 71042 249255 +178213
- Partials 19514 24325 +4811
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
1 similar comment
/retest |
/test all |
/retest |
/test all |
1 similar comment
/test all |
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #54123
Problem Summary:
What changed and how does it work?
InjectExtraProjection forgets to remove duplicated projections.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.