Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove the same projection when to InjectExtraProjection | tidb-test=pr/2349 #54163

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 21, 2024

What problem does this PR solve?

Issue Number: close #54123

Problem Summary:

What changed and how does it work?

InjectExtraProjection forgets to remove duplicated projections.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.9486%. Comparing base (cbdbd76) to head (ae82168).
Report is 18 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54163         +/-   ##
=================================================
- Coverage   74.9123%   55.9486%   -18.9637%     
=================================================
  Files          1520       1644        +124     
  Lines        360958     621048     +260090     
=================================================
+ Hits         270402     347468      +77066     
- Misses        71042     249255     +178213     
- Partials      19514      24325       +4811     
Flag Coverage Δ
integration 37.5874% <97.0588%> (?)
unit 71.7780% <94.1176%> (-2.0258%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 52.7255% <ø> (+4.7015%) ⬆️

@hawkingrei hawkingrei changed the title planner: remove the same projection when to InjectExtraProjection planner: remove the same projection when to InjectExtraProjection | tidb-test=pr/2349 Jun 21, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2024
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

1 similar comment
@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested a review from AilinKid June 22, 2024 04:36
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2024
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested a review from winoros June 23, 2024 09:34
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 24, 2024
Copy link

ti-chi-bot bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 24, 2024
Copy link

ti-chi-bot bot commented Jun 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-24 09:45:12.296908726 +0000 UTC m=+626438.782397550: ☑️ agreed by AilinKid.
  • 2024-06-24 16:05:55.750621178 +0000 UTC m=+649282.236110010: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit d1080e5 into pingcap:master Jun 24, 2024
23 checks passed
@hawkingrei hawkingrei deleted the 54123 branch June 24, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary projection In the query
3 participants