planner: remove the same projection when to InjectExtraProjection

Signed-off-by: Weizhen Wang <[email protected]>
pingcap · Jun 21, 2024 · 9710119 · 9710119
1 parent 537e79e
commit 9710119
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/pkg/planner/core/rule_inject_extra_projection.go b/pkg/planner/core/rule_inject_extra_projection.go
@@ -174,14 +174,15 @@ func InjectProjBelowAgg(aggPlan base.PhysicalPlan, aggFuncs []*aggregation.AggFu
 	}
 
 	for i, item := range groupByItems {
-		if _, isCnst := item.(*expression.Constant); isCnst {
+		it := item
+		if _, isCnst := it.(*expression.Constant); isCnst {
 			continue
 		}
 		idx := slices.IndexFunc(projExprs, func(a expression.Expression) bool {
-			return a.Equal(ectx, groupByItems[i])
+			return a.Equal(ectx, it)
 		})
 		if idx < 0 {
-			projExprs = append(projExprs, item)
+			projExprs = append(projExprs, it)
 			newArg := &expression.Column{
 				UniqueID: aggPlan.SCtx().GetSessionVars().AllocPlanColumnID(),
 				RetType:  item.GetType(ectx),