Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: stop log when full restore failed (#51578) #52104

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51578

What problem does this PR solve?

Issue Number: close #51572

Problem Summary:
too many logs when full restore failed

What changed and how does it work?

stop log when error context canceled

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 26, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 26, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 26, 2024
Signed-off-by: Leavrth <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 27, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 10:25:18.247972645 +0000 UTC m=+2063545.270219033: ☑️ agreed by YuJuncen.
  • 2024-03-27 10:27:14.258540512 +0000 UTC m=+2063661.280786900: ☑️ agreed by Leavrth.

@BornChanger
Copy link
Contributor

BornChanger commented Mar 27, 2024

/test unit-test

@Leavrth
Copy link
Contributor

Leavrth commented Mar 28, 2024

/retest

3 similar comments
@Leavrth
Copy link
Contributor

Leavrth commented Mar 28, 2024

/retest

@Leavrth
Copy link
Contributor

Leavrth commented Mar 28, 2024

/retest

@Leavrth
Copy link
Contributor

Leavrth commented Mar 28, 2024

/retest

@Leavrth
Copy link
Contributor

Leavrth commented Mar 28, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Mar 28, 2024

@Leavrth: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Leavrth <[email protected]>
@Leavrth
Copy link
Contributor

Leavrth commented Mar 28, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Mar 28, 2024

@Leavrth: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor

Leavrth commented Mar 28, 2024

/retest

2 similar comments
@Leavrth
Copy link
Contributor

Leavrth commented Mar 28, 2024

/retest

@BornChanger
Copy link
Contributor

/retest

Signed-off-by: Leavrth <[email protected]>
@Leavrth
Copy link
Contributor

Leavrth commented Mar 29, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Mar 29, 2024

@Leavrth: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Leavrth <[email protected]>
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@78dfdf2). Click here to learn what that means.
The diff coverage is 64.7058%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #52104   +/-   ##
================================================
  Coverage               ?   73.6419%           
================================================
  Files                  ?       1096           
  Lines                  ?     351426           
  Branches               ?          0           
================================================
  Hits                   ?     258797           
  Misses                 ?      75990           
  Partials               ?      16639           

@ti-chi-bot ti-chi-bot bot merged commit cc3e77d into pingcap:release-6.5 Mar 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants