-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: stop log when full restore failed #51578
Conversation
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51578 +/- ##
================================================
+ Coverage 70.7753% 72.7909% +2.0156%
================================================
Files 1464 1473 +9
Lines 436300 444665 +8365
================================================
+ Hits 308793 323676 +14883
+ Misses 108167 100691 -7476
- Partials 19340 20298 +958
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pdclient := mgr.GetPDClient()
cctx, cancel := context.WithCancel(ctx)
cancel()
_, _, err = pdclient.GetTS(cctx)
require.Equal(t, context.Canceled, errors.Cause(err)) // pass
require.NoError(t, err) // Received unexpected error:
// context canceled It is not grpc context cancel error, so we can retry the grpc context cancel error in pd backoff |
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Leavrth <[email protected]>
/ok-to-test |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #51572
Problem Summary:
too many logs when full restore failed
What changed and how does it work?
stop log when error context canceled
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.