Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove the limitation that predicates can't be pushed through Projection on TableDual #51329

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Feb 26, 2024

What problem does this PR solve?

Issue Number: close #50614

Problem Summary:

#35669 disables predicates pushdown on TableDual.
This usually won't cause problems, but when it comes to cases like #50614, many unnecessary predicates with lots of conditions will cause obvious performance regression.

What changed and how does it work?

This PR reverts #35669, which is for fixing #35527.
#35527 itself has already been fixed by #38802, which prevents predicates from being incorrectly pushed through Projection.

As said in #35669, sometimes TableDual doesn't have a schema. This may or may not be considered as a mistake depending on our definition of the semantic of TableDual.
Anyway, TableDual without schema should not cause a problem if the predicates are pushed down correctly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #51329 (b01b5c4) into master (f1410bf) will increase coverage by 0.3512%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51329        +/-   ##
================================================
+ Coverage   72.3723%   72.7235%   +0.3512%     
================================================
  Files          1461       1462         +1     
  Lines        361906     434984     +73078     
================================================
+ Hits         261920     316336     +54416     
- Misses        80639      98692     +18053     
- Partials      19347      19956       +609     
Flag Coverage Δ
integration 48.9113% <ø> (?)
unit 70.3834% <ø> (-1.8454%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.4005% <ø> (+5.0151%) ⬆️

@time-and-fate
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@time-and-fate
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 28, 2024
Copy link

ti-chi-bot bot commented Feb 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 03:39:51.276919775 +0000 UTC m=+933280.024542870: ☑️ agreed by tangenta.
  • 2024-02-28 09:52:48.138970394 +0000 UTC m=+1042056.886593502: ☑️ agreed by winoros.

@time-and-fate
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 27ce02a into pingcap:master Feb 28, 2024
23 checks passed
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 27, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52125.

@time-and-fate
Copy link
Member Author

/cherry-pick release-7.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 27, 2024
@ti-chi-bot
Copy link
Member

@time-and-fate: new pull request created to branch release-7.5: #52165.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Mar 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52166.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 27, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Mar 28, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Mar 28, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql plan changed and performance regression
4 participants