-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: remove the limitation that predicates can't be pushed through Projection
on TableDual
#51329
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51329 +/- ##
================================================
+ Coverage 72.3723% 72.7235% +0.3512%
================================================
Files 1461 1462 +1
Lines 361906 434984 +73078
================================================
+ Hits 261920 316336 +54416
- Misses 80639 98692 +18053
- Partials 19347 19956 +609
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
/cherry-pick release-7.5 |
Signed-off-by: ti-chi-bot <[email protected]>
@time-and-fate: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #50614
Problem Summary:
#35669 disables predicates pushdown on
TableDual
.This usually won't cause problems, but when it comes to cases like #50614, many unnecessary predicates with lots of conditions will cause obvious performance regression.
What changed and how does it work?
This PR reverts #35669, which is for fixing #35527.
#35527 itself has already been fixed by #38802, which prevents predicates from being incorrectly pushed through
Projection
.As said in #35669, sometimes
TableDual
doesn't have aschema
. This may or may not be considered as a mistake depending on our definition of the semantic ofTableDual
.Anyway,
TableDual
withoutschema
should not cause a problem if the predicates are pushed down correctly.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.