-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: fix routine/client leak when get a cached store (#42779) #46143
store: fix routine/client leak when get a cached store (#42779) #46143
Conversation
Signed-off-by: husharp <[email protected]>
65dc8b0
to
1421b3a
Compare
/test unit-test |
@HuSharp: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46143 +/- ##
================================================
Coverage ? 73.6846%
================================================
Files ? 1084
Lines ? 347903
Branches ? 0
================================================
Hits ? 256351
Misses ? 75098
Partials ? 16454 |
@D3Hunter PTAL, thx! |
Signed-off-by: husharp <[email protected]>
94796b7
to
aae73d8
Compare
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
update client-go to sync related pr tikv/client-go#944 for cp #42779 and #42885 PTAL, thx! @D3Hunter @hawkingrei |
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, hawkingrei, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #42779
What problem does this PR solve?
Issue Number: close #42778
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.