Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routine/client leak when get a cached store #42778

Closed
D3Hunter opened this issue Apr 3, 2023 · 0 comments · Fixed by #42779
Closed

routine/client leak when get a cached store #42778

D3Hunter opened this issue Apr 3, 2023 · 0 comments · Fixed by #42779
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.0 severity/moderate sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Apr 3, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

we should close pd client before return cached store. and close resource on err

tidb/store/driver/tikv_driver.go

Line 179 in 8f3328f

return store, nil

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@D3Hunter D3Hunter added the type/bug The issue is confirmed as a bug. label Apr 3, 2023
@D3Hunter D3Hunter mentioned this issue Apr 3, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 4, 2023
@D3Hunter
store: fix routine/client leak when get a cached store (#42779)
38a0852 
close #42778
@ti-chi-bot ti-chi-bot mentioned this issue Apr 4, 2023
Closed
12 tasks
@D3Hunter D3Hunter mentioned this issue Apr 10, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 10, 2023
@D3Hunter
store: fix panic when failed to create pdclient (#42885)
86924ae 
ref #42778
@ti-chi-bot ti-chi-bot mentioned this issue Apr 10, 2023
Merged
12 tasks
ti-chi-bot added a commit that referenced this issue Apr 11, 2023
@ti-chi-bot
store: fix panic when failed to create pdclient (#42885) (#42894)
ac70ae9 
ref #42778
@ti-chi-bot ti-chi-bot mentioned this issue Aug 16, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 18, 2023
@ti-chi-bot
store: fix routine/client leak when get a cached store (#42779) (#46143)
189e059 
close #42778
@ti-chi-bot ti-chi-bot added the affects-6.5 This bug affects the 6.5.x(LTS) versions. label Aug 21, 2023
@D3Hunter D3Hunter added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label Aug 21, 2023
@jebter jebter added the sig/transaction SIG:Transaction label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.0 severity/moderate sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

store: fix routine/client leak when get a cached store pingcap/tidb
3 participants
@D3Hunter @jebter @ti-chi-bot