statistics: avoid large CMSketch affecting the latency of normal query #17542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed their request for review
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #17542 +/- ##
================================================
- Coverage 79.8510% 79.8279% -0.0232%
================================================
Files 520 520
Lines 140067 139743 -324
================================================
- Hits 111845 111554 -291
+ Misses 19275 19239 -36
- Partials 8947 8950 +3 |
|
good catch!!! |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 1, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.0 in PR #17543 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 1, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.1 in PR #17544 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 1, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-4.0 in PR #17545 |
ngaut
pushed a commit
that referenced
this pull request
Jun 1, 2020
sre-bot
added a commit
that referenced
this pull request
Jun 1, 2020
ngaut
pushed a commit
that referenced
this pull request
Jun 2, 2020
bobotu
pushed a commit
to bobotu/tidb
that referenced
this pull request
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
We have captured a runtime trace of tidb-server and observed a large latency caused by GC sweep.
The root cause is the large amount 8K span referenced by
CMSketchand there is a limitation of Go's allocator. In this case, 8K allocation issued byIndexLookUpExecwill take a long time to scan memory spans used byCMSketch.What is changed and how it works?
Memory allocation larger than 32K will never use memory span. The default configuration of
CMSketchwill use 40K memory, so use a single slice is a workaround.This problem can be solved in Go 1.15, so this simple workaround is a good choice before Go 1.15 release.
This test is using v3.0.14 TiDB compiled with Go 1.13.10, but I believe v4.0 and Go 1.14 have the same problem.
Release note