Converting views to Generic CBVs #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: Updating form class inheritance to work properly with GCBV. Fixing Document.folder field definition. Adding view tests. Updating runtests.py and setup.py for template and testing requirements.
Using dj-inmemorystorage.
Fixing merge conflicts. Conflicts: pinax/documents/urls.py pinax/documents/views.py
Also adding .python-version (used by pyenv) to .gitignore.
paltman
added a commit
that referenced
this pull request
Feb 20, 2016
Converting views to Generic CBVs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paltman This is ready for review. I tried squashing commits but failed, sorry.
All tests pass in all environments except when Django==master.
Please check the warning note in views.py DocumentDownload.
#5