Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite views as class based views #5

Closed
paltman opened this issue Feb 4, 2016 · 1 comment
Closed

Rewrite views as class based views #5

paltman opened this issue Feb 4, 2016 · 1 comment
Labels
difficulty: medium

Comments

@paltman
Copy link
Contributor

paltman commented Feb 4, 2016

Currently there is a mix of function and class-based views. We should ship with CBVs to allow for greater extensibility.

  • folder_create => FolderCreateView(LoginRequiredMixin, CreateView)
  • folder_detail => FolderDetailView(LoginRequiredMixin, DetailView)
  • document_create => DocumentCreateView(LoginRequiredMixin, CreateView)
  • document_detail => DocumentDetailView(LoginRequiredMixin, DetailView)
  • document_download => DocumentDownloadView(LoginRequiredMixin, View) (but maybe a DetailView)
  • folder_share => FolderShareView(LoginRequiredMixin, View) (but maybe a DetailView)
  • document_delete => DocumentDeleteView(LoginRequiredMixin, DeleteView)
@paltman paltman mentioned this issue Feb 5, 2016
Closed
@grahamu grahamu mentioned this issue Feb 15, 2016
Merged
@grahamu
Copy link
Contributor

grahamu commented Feb 26, 2016

@paltman Is this issue now resolved?

@paltman paltman closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paltman @grahamu