Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmdline/CLI tests #258

Merged
merged 12 commits into from
Mar 24, 2020
Merged

Add cmdline/CLI tests #258

merged 12 commits into from
Mar 24, 2020

Conversation

Quentame
Copy link
Collaborator

@Quentame Quentame commented Mar 23, 2020 •
edited
Loading

Proposed change

Add cmdline/CLI tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

@Quentame Quentame added this to the 1.0.0 milestone Mar 23, 2020
Quentame
Quentame commented Mar 23, 2020
View reviewed changes
Copy link
Collaborator Author

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review #256 (review)

@Quentame Quentame force-pushed the tests/cmdline branch 2 times, most recently from 78fd1f8 to 263483c Compare March 24, 2020 10:54
@Quentame Quentame merged commit 9588c0d into picklepete:master Mar 24, 2020
@Quentame Quentame deleted the tests/cmdline branch March 24, 2020 11:08
@Quentame Quentame modified the milestones: 1.0.0, 0.9.7 May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.7
Development

Successfully merging this pull request may close these issues.
1 participant
@Quentame