Tests upgrade + tiny lib bump #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentame
force-pushed
the
ci
branch
6 times, most recently
from
eb68826 to
3d40ec1
Compare
Quentame
commented
Mar 23, 2020
pyicloud/base.py
Outdated
| def __init__(self, password): | ||
| self.password = password | ||
| super(PyiCloudPasswordFilter, self).__init__(password) |
There was a problem hiding this comment.
Adding a test about this ?
pyicloud/cmdline.py
Outdated
| location = filename | ||
| pickle_file = open(location, 'wb') | ||
| pickle.dump(data, pickle_file, protocol=pickle.HIGHEST_PROTOCOL) | ||
| pickle.dump(idevice.content, pickle_file, protocol=pickle.HIGHEST_PROTOCOL) |
There was a problem hiding this comment.
Adding a test about this ?
pyicloud/services/account.py
Outdated
| return self._devices | ||
|
|
||
|
|
||
| @six.python_2_unicode_compatible | ||
| class AccountDevice(dict): | ||
| def __init__(self, device_info): | ||
| super(AccountDevice, self).__init__(device_info) |
There was a problem hiding this comment.
Adding a test about this ?
|
First, make the PR unitary |
Quentame
commented
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Tests upgrade + tiny lib bump
Type of change
Example of code:
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: