fix iOS setCookie #196

pichillilorenzo · Nov 19, 2019 · e9286da · e9286da
1 parent 6edf5f0
commit e9286da
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 1.2.2
+
+- Merge "added a shared WKProcessPool for webview instances" [#198](https://github.com/pichillilorenzo/flutter_inappbrowser/pull/198) (thanks to [robertcnst](https://github.com/robertcnst))
+- Fixed iOS setCookie.
+
 ## 1.2.1
 
 - Merge "Add new option to control the contentMode in Android platform" [#101](https://github.com/pichillilorenzo/flutter_inappbrowser/pull/101) (thanks to [DreamBuddy](https://github.com/DreamBuddy))

diff --git a/ios/Classes/MyCookieManager.swift b/ios/Classes/MyCookieManager.swift
@@ -93,8 +93,9 @@ class MyCookieManager: NSObject, FlutterPlugin {
         properties[.secure] = (isSecure != nil && isSecure!) ? "TRUE" : "FALSE"
 
         let cookie = HTTPCookie(properties: properties)!
-        MyCookieManager.httpCookieStore!.setCookie(cookie)
-        result(true)
+        MyCookieManager.httpCookieStore!.setCookie(cookie, completionHandler: {() in
+            result(true)
+        })
     }
 
     public static func getCookies(url: String, result: @escaping FlutterResult) {

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: flutter_inappbrowser
 description: A Flutter plugin that allows you to add an inline webview or open an in-app browser window (inspired by the popular cordova-plugin-inappbrowser).
-version: 1.2.1
+version: 1.2.2
 author: Lorenzo Pichilli <[email protected]>
 homepage: https://github.com/pichillilorenzo/flutter_inappbrowser