Merge pull request #198 from robertcnst/fix_ios_shared_process_pool_w…

…eb_view - added a shared WKProcessPool for webview instances
pichillilorenzo · Nov 19, 2019 · 6edf5f0 · 6edf5f0
2 parents f6353b8 + 5648001
commit 6edf5f0
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/ios/Classes/FlutterWebViewController.swift b/ios/Classes/FlutterWebViewController.swift
@@ -28,7 +28,7 @@ public class FlutterWebViewController: NSObject, FlutterPlatformView {
 
         let options = InAppWebViewOptions()
         options.parse(options: initialOptions)
-        let preWebviewConfiguration = InAppWebView.preWKWebViewConfiguration(options: options)
+        let preWebviewConfiguration = InAppWebView.preWKWebViewConfiguration(options: options, webViewProcessPool: SwiftFlutterPlugin.webViewProcessPool)
 
         webView = InAppWebView(frame: frame, configuration: preWebviewConfiguration, IABController: nil, IAWController: self)
         let channelName = "com.pichillilorenzo/flutter_inappwebview_" + String(viewId)

diff --git a/ios/Classes/InAppBrowserWebViewController.swift b/ios/Classes/InAppBrowserWebViewController.swift
@@ -113,7 +113,7 @@ class InAppBrowserWebViewController: UIViewController, UIScrollViewDelegate, WKU
 
     override func viewWillAppear(_ animated: Bool) {
         if !viewPrepared {
-            let preWebviewConfiguration = InAppWebView.preWKWebViewConfiguration(options: webViewOptions)
+            let preWebviewConfiguration = InAppWebView.preWKWebViewConfiguration(options: webViewOptions, webViewProcessPool: SwiftFlutterPlugin.webViewProcessPool)
             self.webView = InAppWebView(frame: .zero, configuration: preWebviewConfiguration, IABController: self, IAWController: nil)
             self.containerWebView.addSubview(self.webView)
             prepareConstraints()

diff --git a/ios/Classes/InAppWebView.swift b/ios/Classes/InAppWebView.swift
@@ -191,8 +191,9 @@ public class InAppWebView: WKWebView, UIScrollViewDelegate, WKUIDelegate, WKNavi
         }
     }
 
-    public static func preWKWebViewConfiguration(options: InAppWebViewOptions?) -> WKWebViewConfiguration {
+    public static func preWKWebViewConfiguration(options: InAppWebViewOptions?, webViewProcessPool: WKProcessPool) -> WKWebViewConfiguration {
         let configuration = WKWebViewConfiguration()
+        configuration.processPool = webViewProcessPool
 
         if #available(iOS 10.0, *) {
             configuration.mediaTypesRequiringUserActionForPlayback = ((options?.mediaPlaybackRequiresUserGesture)!) ? .all : []

diff --git a/ios/Classes/SwiftFlutterPlugin.swift b/ios/Classes/SwiftFlutterPlugin.swift
@@ -38,6 +38,7 @@ public class SwiftFlutterPlugin: NSObject, FlutterPlugin {
     static var registrar: FlutterPluginRegistrar?
     static var channel: FlutterMethodChannel?
 
+    static let webViewProcessPool: WKProcessPool = WKProcessPool()
     var webViewControllers: [String: InAppBrowserWebViewController?] = [:]
     var safariViewControllers: [String: Any?] = [:]