Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-check-lock option support #947

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Add --no-check-lock option support #947

merged 2 commits into from
Nov 5, 2021

Conversation

RoSk0
Copy link
Contributor

@RoSk0 RoSk0 commented Nov 4, 2021

Q A
Version GrumPHP 1.5.0
Bug? no
New feature? yes
Question? no
Documentation? no
Related tickets #595 , #596 , #645 , #944, #945

composer-normalize introduced --no-check-lock option in 2.7.0 release back in August 2020.

This option is very useful when you work on a library project and you only concerned about the composer.json file but not that much about the lock file that only exists in the development environment for the library itself.

It would be awesome to see it available via configuration for the composer_normalize task.

@RoSk0
Copy link
Contributor Author

RoSk0 commented Nov 4, 2021

The only thing that is missing is tests - unfortunately I haven't figured out this part. ComposerNormalizeSpec added with this task originally gone form the code base...

@veewee veewee added this to the 1.6.0 milestone Nov 5, 2021
@veewee veewee merged commit 2d906ce into phpro:master Nov 5, 2021
@veewee
Copy link
Contributor

veewee commented Nov 5, 2021

Looks nice! Thanks for the addition.

Just to answer your question : we transitioned the task system at some point in time.
The spec tests for the tasks weren't really helpful. That is why we added a new way of testing tasks through phpunit.

Looks like you found that during your PR, so that's nice! :)

@RoSk0 RoSk0 deleted the idea-945 branch November 6, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants