Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add task composer normalize #596

Merged
merged 8 commits into from
May 16, 2019
Merged

Add task composer normalize #596

merged 8 commits into from
May 16, 2019

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Feb 16, 2019 •
edited
Loading

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes

New Task Checklist:

  • Is the README.md file updated?
  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpspec tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

@drupol
Copy link
Contributor Author

drupol commented Feb 16, 2019

I pushed the tests but they are currently failing, I will try to find some time during the weekend to fix them.

@drupol
Copy link
Contributor Author

drupol commented Feb 17, 2019

@localheinz Could you review it before I move it to "Ready for review" ?

localheinz
localheinz reviewed Feb 18, 2019
View reviewed changes
doc/tasks/composer_normalize.md Outdated Show resolved Hide resolved
spec/Task/ComposerNormalizeSpec.php Outdated Show resolved Hide resolved
src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
@drupol drupol marked this pull request as ready for review February 18, 2019 17:56
veewee
veewee reviewed Mar 1, 2019
View reviewed changes
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've added some small remarks.

src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
doc/tasks/composer_normalize.md Outdated Show resolved Hide resolved
src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
@veewee veewee mentioned this pull request Mar 1, 2019
Closed
1 task
veewee
veewee requested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drupol,

There are still some issues left which will cause grumphp to fail.

doc/tasks/composer_normalize.md Outdated Show resolved Hide resolved
src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
src/Task/ComposerNormalize.php Outdated Show resolved Hide resolved
@veewee veewee added this to the 0.15.1 milestone Mar 7, 2019
@Landerstraeten Landerstraeten changed the title Issue #595: Add a new grumphp task: composer normalize Add a new grumphp task: composer normalize May 16, 2019
@Landerstraeten Landerstraeten changed the title Add a new grumphp task: composer normalize Add task composer normalize May 16, 2019
@Landerstraeten Landerstraeten merged commit dcd1da8 into phpro:master May 16, 2019
@Landerstraeten
Copy link
Contributor

Thank you @drupol and @localheinz

@drupol drupol deleted the 595-add-composer-normalize-task branch August 13, 2019 12:13
This was referenced Nov 4, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localheinz localheinz localheinz left review comments

@veewee veewee veewee approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
0.15.1
Development

Successfully merging this pull request may close these issues.
4 participants
@drupol @Landerstraeten @localheinz @veewee