update docs to signify that php-server serves from ./public directory by default, add translations of doc blocks that were missed in previous pr's #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm not in favor of printing a warning. To me, the current behavior is expected and desirable when using the embedded app feature. |
Contributor
Author
|
Okay. It definitely confused me when I tested the embedded app bug someone reported. I only figured it out when I enabled logging in the Caddyfile and figure out that it was trying to serve from a non-existent public directory. I'll remove the code changes, but keep the documentation bits. |
henderkes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1571
accidentally pushed the frankenphp directive to the main branch, so restoring this one under another branch