metrics: register prometheus collectors only if enabled #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fyi @AlliBalliBaba |
IndraGunawan
changed the title
IndraGunawan
changed the title
dunglas
requested changes
Mar 24, 2025
Co-authored-by: Kévin Dunglas <[email protected]>
AlliBalliBaba
approved these changes
Mar 24, 2025
dunglas
requested changes
Mar 24, 2025
Co-authored-by: Kévin Dunglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on this #1450 PR, i noticed that we do register Prometheus collector even though the user does not define
metricsdirective in Caddyfilethis PR adds a check if
metricsis configured then it will register the Prometheus collector