Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fast_add_function removed in PHP 8.3, use add_function #195

Merged
merged 1 commit into from
Jun 18, 2023
Merged

fast_add_function removed in PHP 8.3, use add_function #195

merged 1 commit into from
Jun 18, 2023

Conversation

Jan-E
Copy link
Contributor

@Jan-E Jan-E commented Jun 17, 2023

Quote from UPGRADING.INTERNALS of PHP 8.3:

The fast_add_function() has been removed, use add_function() that will
call the static inline add_function_fast() instead.

To be on the safe side the patch only replaces fast_add_function() by add_function() in PHP 8.3+
Tested while building PHP 8.3.0 Alpha 1 on Windows.

@rtheunissen rtheunissen merged commit 23ddc08 into php-ds:master Jun 18, 2023
@Jan-E Jan-E deleted the no-fast-add-function-php83 branch June 18, 2023 09:14
@Jan-E
Copy link
Contributor Author

Jan-E commented Jun 18, 2023

Top. Thanks

@Jan-E Jan-E mentioned this pull request Jun 19, 2023
Open
@andypost andypost mentioned this pull request Dec 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jan-E @rtheunissen