-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Support for PHP 8.3.x and 9.x? #199
Comments
Used Alpinelinux build with 8.3 to run https://github.com/php-ds/benchmarks and no issues found |
I'll clarify in my case I was on Debian and PHP came from https://packages.sury.org/php/ while I'm not sure where php-ds came from, but looking at the date code in my log, it seems older than the one here: https://packages.sury.org/php/pool/main/p/php-ds/ so maybe I'm pulling from the wrong repo. In either case, I intentionally made this issue generic since it's not clear what the long term support strategy/plan is. It's been years and the repo still says "for PHP 7" |
Thank you for bringing this to my attention, it's about time that the version information is not around PHP 7 anymore, as it was when this project started. I'll take a look at support for 8.3 also, shouldn't be much work. |
@andypost alpine package has the patch for php 8.3 https://git.alpinelinux.org/aports/tree/community/php83-pecl-ds/fix-php83.patch |
@rtheunissen required changes for PHP 8.3 already merged #195 so only new release mentioning new support constraints would be good |
Related #196 |
I'll release a new version on PECL after fixing #200 |
Released on PECL as 1.5.0 |
@rtheunissen please create a tag for release commit, I'm packing the extension for Alpinelinux and it handy to use tag to download composer.json for release to run tests https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/57617 |
@andypost tagged as v1.5.0 — I'll keep tagging releases from now on. |
Thank you a lot! |
The README at the root mentions this extension is for PHP7, but has managed to work for 8.0-8.2. However, it is incompatible with PHP 8.3 (atleast ds 1.4). Could the root readme clarify what the official support plans are for PHP > 7?
For reference, here's the issue with 8.3:
Mostly wondering if it's worth it trying to make
Ds
happen (i was super excited when it first came out) or just to migrate back to the built-in types since every version seems to require delaying updating PHP to get compatibility.The text was updated successfully, but these errors were encountered: