Skip to content

Review: [Stack Monitoring] Logstash migration#1

Closed
matschaffer wants to merge 2 commits intophillipb:logstash-migrationfrom
matschaffer:logstash-migration
Closed

Review: [Stack Monitoring] Logstash migration#1
matschaffer wants to merge 2 commits intophillipb:logstash-migrationfrom
matschaffer:logstash-migration

Conversation

@matschaffer
Copy link

For elastic#113256

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes | ---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still
| supported in non-default Kibana Space and when user switches between spaces. | Multiple nodes—Elasticsearch polling might have race conditions
| when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in
| logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing
| procedure. | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature
| flag or plugin combination still results in our service operational. | See more potential risk
| examples
|

For maintainers

------------------------ >8 ------------------------ Do not modify or remove the line above. Everything below it will be ignored.

Requesting a pull to phillipb:logstash-migration from matschaffer:logstash-migration

Write a message for this pull request. The first block of text is the title and the rest is the description.

I remember we figured this out last week while pairing :)
@matschaffer
Copy link
Author

Closing in favor of elastic#114218

@matschaffer matschaffer closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant