Logstash view cleanup fixes by matschaffer · Pull Request #114218 · elastic/kibana

matschaffer · 2021-10-07T00:53:59Z

Summary

A few code fixes for #113256

Originally from phillipb#1

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

I remember we figured this out last week while pairing :)

elasticmachine · 2021-10-07T00:54:02Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

elasticmachine · 2021-10-07T00:54:02Z

Pinging @elastic/stack-monitoring (Team:Monitoring)

kibanamachine · 2021-10-07T03:22:33Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: bc7e7aa
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup10

Test Failures

Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/certificates·ts.Uptime app with generated data certificates with certs page "before each" hook for "displays certificates"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/112900

[00:00:00]     │
[00:42:51]       └-: Uptime app
[00:42:51]         └-> "before all" hook in "Uptime app"
[00:42:51]         └-: with generated data
[00:42:51]           └-> "before all" hook in "with generated data"
[00:43:44]           └-: certificates
[00:43:44]             └-> "before all" hook in "certificates"
[00:43:58]             └-: with certs
[00:43:58]               └-> "before all" hook for "can navigate to cert page"
[00:43:58]               └-> "before all" hook for "can navigate to cert page"
[00:43:58]                 │ info [x-pack/test/functional/es_archives/uptime/blank] Loading "mappings.json"
[00:43:58]                 │ info [x-pack/test/functional/es_archives/uptime/blank] Loading "data.json"
[00:43:58]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [heartbeat-8-generated-test] creating index, cause [api], templates [], shards [1]/[1]
[00:43:58]                 │ info [x-pack/test/functional/es_archives/uptime/blank] Created index "heartbeat-8-generated-test"
[00:43:58]                 │ debg [x-pack/test/functional/es_archives/uptime/blank] "heartbeat-8-generated-test" settings undefined
[00:43:58]                 │ debg TestSubjects.exists(uptimeSettingsToOverviewLink)
[00:43:58]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=0
[00:43:58]                 │ debg --- retry.tryForTime error: [data-test-subj="uptimeSettingsToOverviewLink"] is not displayed
[00:43:58]                 │ debg navigating to uptime url: http://localhost:6181/app/uptime
[00:43:58]                 │ debg navigate to: http://localhost:6181/app/uptime
[00:43:58]                 │ debg browser[INFO] http://localhost:6181/app/uptime?_t=1633572666705 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:43:58]                 │
[00:43:58]                 │ debg browser[INFO] http://localhost:6181/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:43:58]                 │ debg ... sleep(700) start
[00:43:59]                 │ debg ... sleep(700) end
[00:43:59]                 │ debg returned from get, calling refresh
[00:44:00]                 │ debg browser[INFO] http://localhost:6181/app/uptime?_t=1633572666705 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:44:00]                 │
[00:44:00]                 │ debg browser[INFO] http://localhost:6181/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:44:00]                 │ debg currentUrl = http://localhost:6181/app/uptime
[00:44:00]                 │          appUrl = http://localhost:6181/app/uptime
[00:44:00]                 │ debg TestSubjects.find(kibanaChrome)
[00:44:00]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:44:00]                 │ debg ... sleep(501) start
[00:44:01]                 │ERROR browser[SEVERE] http://localhost:6181/46860/bundles/plugin/uptime/8.0.0/uptime.chunk.1.js 2:3687 "API /api/uptime/monitor/list is not returning expected response, Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.monitor.timespan.lt\" for response" Object
[00:44:01]                 │ debg ... sleep(501) end
[00:44:01]                 │ debg in navigateTo url = http://localhost:6181/app/uptime
[00:44:01]                 │ debg isGlobalLoadingIndicatorVisible
[00:44:01]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:44:01]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:44:03]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:44:03]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:44:03]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:44:03]                 │ debg TestSubjects.exists(uptimeOverviewPage)
[00:44:03]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeOverviewPage"]') with timeout=2000
[00:44:03]                 │ debg TestSubjects.click(superDatePickerApplyTimeButton)
[00:44:03]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:44:03]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:44:03]               └-> can navigate to cert page
[00:44:03]                 └-> "before each" hook: global before each for "can navigate to cert page"
[00:44:03]                 └-> "before each" hook: delete settings for "can navigate to cert page"
[00:44:03]                   │ debg Deleting saved object {
[00:44:03]                   │        type: 'uptime-dynamic-settings',
[00:44:03]                   │        id: 'uptime-dynamic-settings-singleton'
[00:44:03]                   │      }/%s
[00:44:03]                   │ERROR browser[SEVERE] http://localhost:6181/46860/bundles/plugin/uptime/8.0.0/uptime.chunk.1.js 2:3687 "API /api/uptime/monitor/list is not returning expected response, Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.monitor.timespan.lt\" for response" Object
[00:44:03]                 └-> "before each" hook: load heartbeat data for "can navigate to cert page"
[00:44:03]                   │ info [x-pack/test/functional/es_archives/uptime/blank] Loading "mappings.json"
[00:44:03]                   │ info [x-pack/test/functional/es_archives/uptime/blank] Loading "data.json"
[00:44:03]                   │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [heartbeat-8-generated-test/1-CxY1GeTGujHTwcWDHIfQ] deleting index
[00:44:03]                   │ info [x-pack/test/functional/es_archives/uptime/blank] Deleted existing index "heartbeat-8-generated-test"
[00:44:03]                   │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [heartbeat-8-generated-test] creating index, cause [api], templates [], shards [1]/[1]
[00:44:03]                   │ info [x-pack/test/functional/es_archives/uptime/blank] Created index "heartbeat-8-generated-test"
[00:44:03]                   │ debg [x-pack/test/functional/es_archives/uptime/blank] "heartbeat-8-generated-test" settings undefined
[00:44:03]                 └-> "before each" hook for "can navigate to cert page"
[00:44:04]                 │ debg isGlobalLoadingIndicatorVisible
[00:44:04]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:44:04]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:44:05]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:44:06]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:44:06]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:44:06]                 │ debg TestSubjects.exists(data-missing)
[00:44:06]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="data-missing"]') with timeout=2500
[00:44:08]                 │ debg --- retry.tryForTime error: [data-test-subj="data-missing"] is not displayed
[00:44:09]                 │ debg TestSubjects.missingOrFail(data-missing)
[00:44:09]                 │ debg Find.waitForDeletedByCssSelector('[data-test-subj="data-missing"]') with timeout=2500
[00:44:09]                 │ debg Find.existsByCssSelector('[href="/app/uptime/certificates"]') with timeout=2500
[00:44:09]                 │ debg TestSubjects.exists(uptimeCertificatesPage)
[00:44:09]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeCertificatesPage"]') with timeout=0
[00:44:09]                 │ debg --- retry.tryForTime error: [data-test-subj="uptimeCertificatesPage"] is not displayed
[00:44:10]                 │ debg Find.existsByCssSelector('[href="/app/uptime/certificates"]') with timeout=0
[00:44:10]                 │ debg Find.clickByCssSelector('[href="/app/uptime/certificates"]') with timeout=10000
[00:44:10]                 │ debg Find.findByCssSelector('[href="/app/uptime/certificates"]') with timeout=10000
[00:44:10]                 │ debg TestSubjects.exists(uptimeCertificatesPage)
[00:44:10]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeCertificatesPage"]') with timeout=120000
[00:44:10]                 └- ✓ pass  (6.3s) "Uptime app with generated data certificates with certs can navigate to cert page"
[00:44:10]               └-> "after each" hook: unload for "can navigate to cert page"
[00:44:10]                 │ info [x-pack/test/functional/es_archives/uptime/blank] Unloading indices from "mappings.json"
[00:44:10]                 │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [heartbeat-8-generated-test/xo83fD7bRCCwSJamsaa_Aw] deleting index
[00:44:10]                 │ info [x-pack/test/functional/es_archives/uptime/blank] Deleted existing index "heartbeat-8-generated-test"
[00:44:10]                 │ info [x-pack/test/functional/es_archives/uptime/blank] Unloading indices from "data.json"
[00:44:10]               └-: page
[00:44:10]                 └-> "before all" hook for "displays certificates"
[00:44:10]                 └-> displays certificates
[00:44:10]                   └-> "before each" hook: global before each for "displays certificates"
[00:44:10]                   └-> "before each" hook: delete settings for "displays certificates"
[00:44:10]                     │ debg Deleting saved object {
[00:44:10]                     │        type: 'uptime-dynamic-settings',
[00:44:10]                     │        id: 'uptime-dynamic-settings-singleton'
[00:44:10]                     │      }/%s
[00:44:10]                   └-> "before each" hook: load heartbeat data for "displays certificates"
[00:44:10]                     │ info [x-pack/test/functional/es_archives/uptime/blank] Loading "mappings.json"
[00:44:10]                     │ info [x-pack/test/functional/es_archives/uptime/blank] Loading "data.json"
[00:44:10]                     │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [heartbeat-8-generated-test] creating index, cause [api], templates [], shards [1]/[1]
[00:44:10]                     │ info [x-pack/test/functional/es_archives/uptime/blank] Created index "heartbeat-8-generated-test"
[00:44:10]                     │ debg [x-pack/test/functional/es_archives/uptime/blank] "heartbeat-8-generated-test" settings undefined
[00:44:10]                   └-> "before each" hook for "displays certificates"
[00:44:10]                   └-> "before each" hook for "displays certificates"
[00:44:10]                     │ debg TestSubjects.exists(uptimeCertificatesPage)
[00:44:10]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeCertificatesPage"]') with timeout=0
[00:44:11]                     │ debg TestSubjects.click(superDatePickerApplyTimeButton)
[00:44:11]                     │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:44:11]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:44:21]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:44:21]                     │      Wait timed out after 10049ms
[00:44:21]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:44:31]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:44:31]                     │      Wait timed out after 10035ms
[00:44:32]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:44:42]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:44:42]                     │      Wait timed out after 10027ms
[00:44:42]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:44:52]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:44:52]                     │      Wait timed out after 10005ms
[00:44:53]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:45:03]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:45:03]                     │      Wait timed out after 10027ms
[00:45:03]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:45:13]                     │ debg --- retry.try failed again with the same message...
[00:45:14]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:45:24]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:45:24]                     │      Wait timed out after 10051ms
[00:45:24]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:45:34]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:45:34]                     │      Wait timed out after 10056ms
[00:45:35]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:45:45]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:45:45]                     │      Wait timed out after 10028ms
[00:45:45]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:45:55]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:45:55]                     │      Wait timed out after 10011ms
[00:45:56]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:46:06]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:46:06]                     │      Wait timed out after 10033ms
[00:46:06]                     │ debg Find.findByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=10000
[00:46:16]                     │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:46:16]                     │      Wait timed out after 10040ms
[00:46:17]                     │ info Taking screenshot "/dev/shm/workspace/parallel/8/kibana/x-pack/test/functional/screenshots/failure/Uptime app with generated data certificates with certs page _before each_ hook for _displays certificates_.png"
[00:46:17]                     │ info Current URL is: http://localhost:6181/app/uptime/certificates
[00:46:17]                     │ info Saving page source to: /dev/shm/workspace/parallel/8/kibana/x-pack/test/functional/failure_debug/html/Uptime app with generated data certificates with certs page _before each_ hook for _displays certificates_.html
[00:46:17]                     └- ✖ fail: Uptime app with generated data certificates with certs page "before each" hook for "displays certificates"
[00:46:17]                     │      Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
[00:46:17]                     │ Wait timed out after 10040ms
[00:46:17]                     │     at /dev/shm/workspace/parallel/8/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:46:17]                     │     at runMicrotasks (<anonymous>)
[00:46:17]                     │     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:46:17]                     │       at onFailure (/dev/shm/workspace/parallel/8/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:46:17]                     │       at retryForSuccess (/dev/shm/workspace/parallel/8/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:46:17]                     │       at RetryService.try (/dev/shm/workspace/parallel/8/kibana/test/common/services/retry/retry.ts:31:12)
[00:46:17]                     │       at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/8/kibana/test/functional/services/common/find.ts:360:5)
[00:46:17]                     │       at TestSubjects.click (/dev/shm/workspace/parallel/8/kibana/test/functional/services/common/test_subjects.ts:105:5)
[00:46:17]                     │       at refreshApp (test/functional/services/uptime/navigation.ts:32:5)
[00:46:17]                     │       at Object.refreshApp (test/functional/services/uptime/navigation.ts:37:7)
[00:46:17]                     │       at Context.<anonymous> (test/functional/apps/uptime/certificates.ts:67:11)
[00:46:17]                     │       at Object.apply (/dev/shm/workspace/parallel/8/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:46:17]                     │ 
[00:46:17]                     │

Stack Trace

Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerApplyTimeButton"])
Wait timed out after 10040ms
    at /dev/shm/workspace/parallel/8/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at onFailure (/dev/shm/workspace/parallel/8/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/8/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at RetryService.try (/dev/shm/workspace/parallel/8/kibana/test/common/services/retry/retry.ts:31:12)
    at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/8/kibana/test/functional/services/common/find.ts:360:5)
    at TestSubjects.click (/dev/shm/workspace/parallel/8/kibana/test/functional/services/common/test_subjects.ts:105:5)
    at refreshApp (test/functional/services/uptime/navigation.ts:32:5)
    at Object.refreshApp (test/functional/services/uptime/navigation.ts:37:7)
    at Context.<anonymous> (test/functional/apps/uptime/certificates.ts:67:11)
    at Object.apply (/dev/shm/workspace/parallel/8/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`monitoring`	1.1MB	1.1MB	-157.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

kibanamachine · 2021-10-07T15:13:25Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Fix route ordering/duplication * Take out "IDK" comments I remember we figured this out last week while pairing :)

kibanamachine · 2021-10-11T15:15:01Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

* Fix route ordering/duplication * Take out "IDK" comments I remember we figured this out last week while pairing :) Co-authored-by: Mat Schaffer <mat@elastic.co>

matschaffer added 2 commits October 7, 2021 00:52

Fix route ordering/duplication

18e6c4a

Take out "IDK" comments

bc7e7aa

I remember we figured this out last week while pairing :)

matschaffer self-assigned this Oct 7, 2021

matschaffer requested a review from a team as a code owner October 7, 2021 00:54

matschaffer requested review from a team October 7, 2021 00:54

matschaffer mentioned this pull request Oct 7, 2021

Review: [Stack Monitoring] Logstash migration phillipb/kibana#1

Closed

2 tasks

matschaffer changed the title ~~111759 cleanup fixes~~ Logstash view cleanup fixes Oct 7, 2021

matschaffer enabled auto-merge (squash) October 7, 2021 05:09

estermv approved these changes Oct 7, 2021

View reviewed changes

matschaffer merged commit a5f4304 into elastic:master Oct 7, 2021

kibanamachine mentioned this pull request Oct 7, 2021

[7.x] Logstash view cleanup fixes (#114218) #114302

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 7, 2021

Logstash view cleanup fixes (elastic#114218)

81c9026

* Fix route ordering/duplication * Take out "IDK" comments I remember we figured this out last week while pairing :)

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021

matschaffer deleted the 111759-cleanup-fixes branch October 11, 2021 15:15

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logstash view cleanup fixes#114218

Logstash view cleanup fixes#114218
matschaffer merged 2 commits intoelastic:masterfrom
matschaffer:111759-cleanup-fixes

matschaffer commented Oct 7, 2021

Uh oh!

elasticmachine commented Oct 7, 2021

Uh oh!

elasticmachine commented Oct 7, 2021

Uh oh!

kibanamachine commented Oct 7, 2021

Standard Out

Stack Trace

Uh oh!

kibanamachine commented Oct 7, 2021

Uh oh!

kibanamachine commented Oct 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

matschaffer commented Oct 7, 2021

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

elasticmachine commented Oct 7, 2021

Uh oh!

elasticmachine commented Oct 7, 2021

Uh oh!

kibanamachine commented Oct 7, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Async chunks

Uh oh!

kibanamachine commented Oct 7, 2021

💚 Backport successful

Uh oh!

kibanamachine commented Oct 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants