fix: adding missing argument --jitconfig for ephemeral windows runner (#3950)

[ardole]

Update of start-runner.ps1 to make it able to connect windows ephemeral runners

[npalm]

The change looks good. But when testing the instance is not getting ready. I have added enable_ephemeral_runners: true to the configuration in the examples for multi-runners (examples/multi-runners/templates/.

Without ephemeral instances (no jit) instances are getting started and registered. But once setting ephemeral, which by default using JIT the instance is not getting ready.

Can you share you test details, or adjust the multi-runner exampl to test?

[ardole]

The change looks good. But when testing the instance is not getting ready. I have added enable_ephemeral_runners: true to the configuration in the examples for multi-runners (examples/multi-runners/templates/.

Without ephemeral instances (no jit) instances are getting started and registered. But once setting ephemeral, which by default using JIT the instance is not getting ready.

Can you share you test details, or adjust the multi-runner exampl to test?

With this change i'm able to start and register both ephemeral and non-ephemeral runners.

Here is the context i use:

• github runner v2.317.0
• module_version downloaded v5.7.1

I use a multi runner configuration, org runner with a pool_config, here is the yaml i use

matcherConfig:
  exactMatch: true
  labelMatchers:
    - [self-hosted, windows, x64, servercore-2022]
fifo: true
runner_config:
  runner_os: windows
  runner_architecture: x64
  runner_name_prefix: servercore-2022-x64_
  enable_ssm_on_runners: true
  runner_boot_time_in_minutes: 5
  instance_types:
    - m5.large
    - c5.large
  runners_maximum_count: 1
  delay_webhook_event: 5
  scale_down_schedule_expression: cron(* * * * ? *)
  enable_ephemeral_runners: true
  pool_runner_owner: "my-org"
  pool_config:
    - size: 2
      schedule_expression: "cron(*/2 7-19 ? * MON,TUE,WED,THU,FRI *)"
  ami_filter:
    name:
      - my-wincore-ami-*
    state:
      - available
  ami_owners:
    - "my-account"
  create_service_linked_role_spot: true
  enable_organization_runners: true

I tried enable_ephemeral_runners: true and enable_ephemeral_runners: false and it works in both case.

@npalm i'm not sure to add my pool configuration in the example, would you like to test from your side with this configuration and let me know if you still have the same issue ?

[npalm]

@ardole finally found time to check the PR. For some reason got it not working. I have created a slightly modified version in this PR #4164

[npalm]

@ardole would you have time to run a quick cross check on PR #4164