fix: Adding github URL to config.cmd

[rfsmart-bcleary]

#3737 This adds the variable gh_url, creates a SSM parameter containing the value from gh_url, and passes in the value of gh_url to the config.cmd call.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

[dhlaurap]

Hello, I am running into this issue, when could this be available in a release?

[dhlaurap]

I was just looking at this more closely and since multiple repos can use the runner would it be better if the webhook lambda stored the repo URL (from the webhook payload) into SSM for the runner to pick-up when running the user_data script?

[jonanderson10]

+1 I am seeing this issue as well

[dhlaurap]

I actually ended up fixing this by using a custom image and modifying the start-runner script by removing the .\config.cmd call and adding the --jitconfig argument to the run.cmd action like this:

$action = New-ScheduledTaskAction -WorkingDirectory "$pwd" -Execute "run.cmd" -Argument "--jitconfig $config"

From what I could gather, a similar fix went into the linux start-runner script but the Windows one was never fixed.

Adding the --url argument did not fix it when I was trying to figure this out btw, it started asking for the --token arg and then I got another error. Eventually found that --jitconfig is what I needed.

[ardole]

@dhlaurap can you confirm which version of the github runner are you using please ?

• i face the same issue with --token, to me its Configuration tries to use the registration endpoint even when passed --token <token>  actions/runner#1882

• your solution with jitconfig seems to not work with v2.317.0 argument is not recognized and nothing better with argument ephemeral. i'm wondering why the start-runner.ps1 and start-runner.sh are different because for windows platforms enable_ephemeral_runners and enable_jit_config are simply ignored, runner is always starting as a service.

• @rfsmart-bcleary i can confirm that adding --url $gh_url is not enough on latest version of runner, --token or --pat is required.

this project is great but seems to suffer of a lack of testability (or i haven't found it), can somebody give tricks on how to quickly test the AMI without need to deploy the whole lambdas ? for instance start-runner.ps1 depends on a ssm-parameters and registration done in lambdas.

[dhlaurap]

Just confirmed it is currently running with the github runner version 2.317.0. I should mention we are using ephemeral runners with a custom AMI and a warming pool. Our setup is very similar to the "ephemeral" example but using windows runners.

Could it be that your $config object is missing something? I didn't have to change it but I am not sure how it's assembled since it comes from SSM.

[ardole]

You are right, something was wrong with the $config that i generated manually to debug.
After new try i was able to make it working with the argument you suggested.

I opened a new issue #3950 and suggest a simple fix #3951