Skip to content

Coreir operator inlining #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2020
Merged

Coreir operator inlining #523

merged 3 commits into from
Jan 11, 2020

Conversation

@leonardt
Copy link
Collaborator

@leonardt leonardt commented Jan 6, 2020

@leonardt leonardt requested review from rdaly525 and rsetaluri January 6, 2020 19:42
rdaly525
rdaly525 approved these changes Jan 6, 2020
View reviewed changes
Copy link
Collaborator

@rdaly525 rdaly525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although we should probably have a way to remove leading 0s on verilog constants.

@leonardt leonardt merged commit d8c6fde into master Jan 11, 2020
@leonardt leonardt deleted the coreir-verilog-inline branch January 11, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsetaluri rsetaluri rsetaluri approved these changes

@rdaly525 rdaly525 rdaly525 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leonardt @rsetaluri @rdaly525