-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review MySQL default null and nullable column definition #14974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions, probably due to the fact that the changes are not quite clear to me. There is no issue link, nor PR description
Co-authored-by: Serghei Iakovlev <[email protected]>
Added link of previous PR (#14888) in the description. |
Updated explanation into description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thank you |
Hello!
In raising this pull request, I confirm the following:
Current PR fixes previous PRs (#14888) behavior, when it wasn't possible to specify
NULL
in column definition, as some of types requires it, if column need to be nullable.For example:
This is NOT NULL
This is NULL, with default NULL
This is also NULL, with default NULL
Two last examples was not possible to generate before this PR.
Also, moved
NULL/NOT NULL
beforeDEFAULT
.Before:
After
Previous branch - #14973
Thanks