Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review MySQL default null and nullable column definition #14973

Closed
wants to merge 427 commits into from
Closed

Review MySQL default null and nullable column definition #14973

wants to merge 427 commits into from

Conversation

Jeckerson
Copy link
Member

Hello!

  • Type: bug fix | code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Thanks

niden and others added 30 commits February 19, 2020 14:03
@niden
[#14734] - Renamed cat methods to append
cfb33db
@niden
[#14734] - Corrected some Crypt tests (why not); Adjusted "cat" methods
e4a6843
@niden
[#14734] - PHPCS and corrected class name in tests
1aad7ca
@niden
[#14734] - Corrected crypt test
71ea05f
@niden
[#14734] - PSR correction and type for log level
4035428
@niden
[#14734] - Removed crypt tests (error in merging)
fa8ae60
@niden
[#14734] - Minor change to the factory
58bbc85
@niden
[#14679] - Added warning when a filter does not exist during sanitize
62ace4e
@niden
[#14679] - Updated changelog
d8901d6
@niden
[#14679] - Correction for empty values
66f29ad
@Jurigag @niden
[#14871] - Add test for get active handler with lazy loader
bd701af
@niden
[#14871] - Updated test
d191248
@Jurigag @niden
[#14871] - Add lazy loader handler get
6867de4
@niden
[#14871] - PHPCS
5bbb9c1
@niden
[#14871] - Minor change to the test
dad9e5a
@niden
[#14871] - Removed generated files
469c7f1
@ruudboon
Merge pull request #14872 from niden/T14871-lazy-loader
24b358b 
T14871 lazy loader
@sergeyklay
Regenerate C code for ext dir [ci skip]
11a47be 
/cc @niden @ruudboon
@ekmst @niden
Removed cookie binding to session
5e81386
@ekmst @niden
Updated changelog [skip ci]
4b1aad1
@niden
[#13856] - Added link tests
609f1b7
@niden
[#13856] - Added exceptions for JWT
13849cb
@niden
[#13856] -
1a9658d
@niden
[#13856] - Added Signers - None/HMAC
36e083e
@niden
[#13856] - Added validator class
915fcba
@niden
[#13856] - Added Builder class
5040102
@niden
[#13856] - Added Token and Parser
38f184a
@niden
[#13856] - Minor corrections
16c9025
@niden
[#13856] - Corrected Signature class
44abd23
@niden
[#13856] - Added Base64 helper and minor correction to audience (buil…
93a2961 
…der)
@sergeyklay sergeyklay force-pushed the fix/mysql-default-null branch from 5e41e8a to 4f50c77 Compare May 2, 2020 07:24
@Jeckerson Jeckerson mentioned this pull request May 2, 2020
Merged
5 tasks
@Jeckerson Jeckerson closed this May 2, 2020
@Jeckerson Jeckerson deleted the fix/mysql-default-null branch May 2, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden Awaiting requested review from niden

@sergeyklay sergeyklay Awaiting requested review from sergeyklay

@ruudboon ruudboon Awaiting requested review from ruudboon

Assignees

@Jeckerson Jeckerson

Labels
bug A bug report
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Jeckerson @niden @Jurigag @ruudboon @sergeyklay @ekmst @jenovateurs @BeMySlaveDarlin