Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed MacOS char issue #14836

Merged
merged 6 commits into from
Feb 11, 2020
Merged

Fixed MacOS char issue #14836

merged 6 commits into from
Feb 11, 2020

Conversation

ruudboon
Copy link
Member

@ruudboon ruudboon commented Feb 11, 2020 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Test are already in place and are currently failing under OSX.

@ruudboon ruudboon requested review from niden and Jeckerson February 11, 2020 13:32
@ruudboon ruudboon merged commit 14448fb into phalcon:4.0.x Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

@niden niden Awaiting requested review from niden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruudboon @Jeckerson